Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserved resources available again after reloading CasC configuration #650

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a0934f6
NPE during the release of a lock
mPokornyETM Jan 2, 2024
15b16e9
API-properties
mPokornyETM Jan 2, 2024
16e6c6e
Merge branch 'jenkinsci:master' into master
mPokornyETM Jan 7, 2024
e22ac9f
Merge branch 'jenkinsci:master' into master
mPokornyETM Jan 10, 2024
884f370
Merge branch 'jenkinsci:master' into master
mPokornyETM Jan 11, 2024
860f651
Merge branch 'jenkinsci:master' into master
mPokornyETM Jan 17, 2024
7f55645
Merge branch 'jenkinsci:master' into master
mPokornyETM Jan 17, 2024
42f54d8
Merge branch 'jenkinsci:master' into master
mPokornyETM Jan 19, 2024
4b8b4ad
Merge branch 'jenkinsci:master' into master
mPokornyETM Feb 9, 2024
cd721c4
Merge branch 'jenkinsci:master' into master
mPokornyETM Feb 15, 2024
058a263
Merge branch 'jenkinsci:master' into master
mPokornyETM Feb 24, 2024
2392700
Merge branch 'jenkinsci:master' into master
mPokornyETM Mar 12, 2024
e6ff31f
Merge remote-tracking branch 'upstream/master'
mPokornyETM Mar 19, 2024
a1b5c5a
Merge branch 'jenkinsci:master' into master
mPokornyETM Apr 5, 2024
5f7d6b8
Merge branch 'jenkinsci:master' into master
mPokornyETM Apr 26, 2024
6cde119
Reserved resources available again after reloading CasC configuration
mPokornyETM Apr 26, 2024
d7c6d78
Merge branch 'master' into feature/remove-reservedBy-from-JCAC
mPokornyETM May 6, 2024
861833e
Merge branch 'jenkinsci:master' into master
mPokornyETM Jun 13, 2024
6ba1685
Merge branch 'master' into feature/remove-reservedBy-from-JCAC
mPokornyETM Aug 15, 2024
8a710cd
Update ConfigurationAsCodeTest.java
mPokornyETM Aug 15, 2024
1757b31
Merge branch 'jenkinsci:master' into master
mPokornyETM Sep 17, 2024
d0e2d96
Merge branch 'master' into feature/remove-reservedBy-from-JCAC
mPokornyETM Sep 17, 2024
69dc998
format code
mPokornyETM Sep 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ unclassified:
- name: "S7_1200_1"
description: "S7 PLC model 1200"
labels: "plc:S7 model:1200"
reservedBy: "Reserved due maintenance window"
- name: "S7_1200_2"
labels: "plc:S7 model:1200"
- name: "Resource-with-properties"
Expand All @@ -314,7 +313,7 @@ unclassified:
value: "Value"
```

Properties *description*, *labels* and *reservedBy* are optional.
Properties *description*, *labels* and *properties* are optional.

----

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ public class LockableResource extends AbstractDescribableImpl<LockableResource>
private transient String labels = null;

private List<String> labelsAsList = new ArrayList<>();
private String reservedBy = null;
private Date reservedTimestamp = null;
private transient String reservedBy = null;
private transient Date reservedTimestamp = null;
private String note = "";

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
<f:entry title="${%entry.labels.title}" field="labels">
<f:textbox/>
</f:entry>
<f:entry title="${%entry.reservedBy.title}" field="reservedBy">
<f:textbox/>
</f:entry>
<f:entry title="${%entry.properties.title}">
<f:repeatableProperty field="properties" header="" minimum="0" add="${%entry.properties.add}">
<f:block>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
entry.name.title=Name
entry.description.title=Description
entry.labels.title=Labels
entry.reservedBy.title=Reserved by
entry.properties.title=Properties
entry.properties.add=Add Property
entry.properties.delete=Delete Property
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@

entry.name.title=Jm\u00e9no
entry.description.title=Popis
entry.labels.title=Popisky
entry.reservedBy.title=Rezervace u\u017eivatelem
entry.labels.title=Popisky
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@

entry.name.title=Name
entry.description.title=Beschreibung
entry.labels.title=Labels
entry.reservedBy.title=Reserviert durch
entry.labels.title=Labels
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
entry.name.title=Nom
entry.description.title=Description
entry.labels.title=Libell\u00e9s
entry.reservedBy.title=R\u00e9serv\u00e9e par
entry.properties.title=Propri\u00e9t\u00e9s
entry.properties.add=Ajouter une propri\u00e9t\u00e9
entry.properties.delete=Supprimer une propri\u00e9t\u00e9
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@

entry.name.title=Meno
entry.description.title=Popis
entry.labels.title=\u0160t\u00edtky
entry.reservedBy.title=Rezervovan\u00e9 u\u017e\u00edvate\u013eom
entry.labels.title=\u0160t\u00edtky
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ public void should_support_configuration_as_code() {
assertEquals("Resource_A", declaredResource.getName());
assertEquals("Description_A", declaredResource.getDescription());
assertEquals("Label_A", declaredResource.getLabels());
assertEquals("Reserved_A", declaredResource.getReservedBy());
// not supported in JCaC
// assertEquals("Reserved_A", declaredResource.getReservedBy());
assertEquals("Note A", declaredResource.getNote());

assertEquals(
Expand All @@ -54,7 +55,8 @@ public void should_support_configuration_as_code() {
assertEquals("Resource_A", resource.getName());
assertEquals("Description_A", resource.getDescription());
assertEquals("Label_A", resource.getLabels());
assertEquals("Reserved_A", resource.getReservedBy());
// not supported in JCaC
// assertEquals("Reserved_A", resource.getReservedBy());
assertEquals("Note A", resource.getNote());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ declaredResources:
labels: "Label_A"
name: "Resource_A"
note: "Note A"
reservedBy: "Reserved_A"
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ unclassified:
- description: "Description_A"
labels: "Label_A"
name: "Resource_A"
reservedBy: "Reserved_A"
note: "Note A"