Reserved resources available again after reloading CasC configuration

[mPokornyETM]

fix #527

Testing done

Manuel tests in config page

Create jenkins instance with JCAC
Reserve resource in LRM page
restart jenkins
Resource is still reserved

Proposed upgrade guidelines

N/A

Localizations

N/A

Submitter checklist

• The Jira / Github issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
  • The changelog generator for plugins uses the pull request title as the changelog entry.
  • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.

[manosnoam]

Thanks for this PR @mPokornyETM.
Was it not merged yet due to some checks ?

[mPokornyETM]

Thanks for this PR @mPokornyETM. Was it not merged yet due to some checks ?

It has failed last time. I have no idea. It is long time ago. I merged master again into this branch. We will see if it works. WHen are the check green now, we canmerge it.

[manosnoam]

It has failed last time. I have no idea. It is long time ago. I merged master again into this branch. We will see if it works. WHen are the check green now, we canmerge it.

Checks failed on expected:<Reserved_A> but was:<null> , I think you need to update the test too:

lockable-resources-plugin/src/test/java/org/jenkins/plugins/lockableresources/ConfigurationAsCodeTest.java

Line 45 in f1ecb60

assertEquals("Reserved_A", declaredResource.getReservedBy());

[mPokornyETM]

It has failed last time. I have no idea. It is long time ago. I merged master again into this branch. We will see if it works. WHen are the check green now, we canmerge it.

Checks failed on expected:<Reserved_A> but was:<null> , I think you need to update the test too:

lockable-resources-plugin/src/test/java/org/jenkins/plugins/lockableresources/ConfigurationAsCodeTest.java

Line 45 in f1ecb60

assertEquals("Reserved_A", declaredResource.getReservedBy());

thx for hit. I changed the test. Maybe now. But you are welcome to review this changes ;-)

[manosnoam]

thx for hit. I changed the test. Maybe now. But you are welcome to review this changes ;-)

I think now ConfigurationAsCodeTest.java needs a formatting fix with mvn spotless:apply

[manosnoam]

All checks passed!
Who can review and approve?

[mPokornyETM]

All checks passed! Who can review and approve?

you ;-)

[roded]

Hi, really looking forward for this fix.
I tried upgrading to the latest release which includes this fix and am still seeing the locks released after both a Jenkins restart or a CasC reload.

[mPokornyETM]

which version do used? The release '1310.v99ca_947ed698' has been published 1 hour ago. Has you this version?

[roded]

Yeah, I've upgraded just for this fix.

[kaltsi]

Happened to me too after a jenkins restart.
I was running Jenkins 2.462.1, updated plugins, upgraded Jenkins to 2.462.2 and updated plugins again.

All manually reserved resources had been released.

[kobihk]

+1
After "Reload existing configuration" all the reserved resources were released to me too
with:
Jenkins Version 2.452.4
Lockable Resources plugin Version1310.v99ca_947ed698

[mPokornyETM]

Happened to me too after a jenkins restart. I was running Jenkins 2.462.1, updated plugins, upgraded Jenkins to 2.462.2 and updated plugins again.

All manually reserved resources had been released.

I see, my mistake. I does not understand it correctly. So I will revert the changes, open the issue again and try to find some other solution.