-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update signing procedure #1075
Draft
ann0see
wants to merge
2
commits into
jamulussoftware:next-release
Choose a base branch
from
ann0see:fixSigningMac
base: next-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update signing procedure #1075
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -276,7 +276,7 @@ Current state: <!-- Planning|Translations (beta)|Code freeze (rc)|Released --> | |||||
- [ ] Agree to de-tag unfinished Issues/PRs. | ||||||
- [ ] Declare a freeze for code and website by updating this Issue and adding a comment. PRs can still be worked on and may get reviewed, but must not be merged unless agreed explicitly. | ||||||
- [ ] Check the `needs documentation` label for any outstanding PRs flagged for this release and remove that label if done. | ||||||
- [ ] Check ./Jamulus -h output against the [Include-Client](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Client-Commands.md)/[Server-Commands](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Server-Commands.md).md pages and [man page (distributions/Jamulus.1)[(https://github.com/jamulussoftware/jamulus/blob/main/distributions/Jamulus.1). Update if necessary. | ||||||
- [ ] Check ./Jamulus -h output against the [Include-Client](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Client-Commands.md)/[Server-Commands](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Server-Commands.md).md pages and [man page (distributions/Jamulus.1)](https://github.com/jamulussoftware/jamulus/blob/main/distributions/Jamulus.1). Update if necessary. | ||||||
- [ ] Start Website translations | ||||||
- [ ] [Check for broken links](https://github.com/jamulussoftware/jamuluswebsite/blob/release/contribute/en/Release-Process.md#website-check-links) | ||||||
- [ ] Open a Pull Request from `next-release` to release, set it as "Draft", sanity check for conflicts and any obvious problems. | ||||||
|
@@ -290,7 +290,7 @@ Current state: <!-- Planning|Translations (beta)|Code freeze (rc)|Released --> | |||||
- [ ] Create a translation issue for each language with `tools/create-translation-issues.sh` using `app` argument. | ||||||
- [ ] [Update the Changelog](https://jamulus.io/contribute/Release-Process#updating-the-changelog) | ||||||
- [ ] [Tag a beta release](https://jamulus.io/contribute/Release-Process#steps-for-a-specific-release) | ||||||
- [ ] Inform emlynmac for signing on macOS, and upload signed binary from [his repo](https://github.com/emlynmac/jamulus/releases/) to [ours](https://github.com/jamulussoftware/jamulus/releases/) | ||||||
- [ ] Push the tag to the [ann0see/jamulussign](https://github.com/ann0see/jamulussign/) repository for signing on macOS, and upload signed binary from [the signing repo](https://github.com/ann0see/jamulussign/releases) to [the official one](https://github.com/jamulussoftware/jamulus/releases/) | ||||||
- [ ] Announce the beta release on Github Discussions. Pin the thread. | ||||||
- [ ] Get feedback on the stability and resource usage (memleaks?, crashes?, installation issues?) of the beta release | ||||||
- [ ] Finish App translations | ||||||
|
@@ -302,14 +302,14 @@ Current state: <!-- Planning|Translations (beta)|Code freeze (rc)|Released --> | |||||
- [ ] [Check for broken links](https://github.com/jamulussoftware/jamuluswebsite/blob/release/contribute/en/Release-Process.md#website-check-links) | ||||||
- [ ] Check the milestone for mergable stuff again | ||||||
- [ ] [Update the Changelog](https://jamulus.io/contribute/Release-Process#updating-the-changelog) | ||||||
- [ ] [Tag a release candidate](https://jamulus.io/contribute/Release-Process#steps-for-a-specific-release) (inform emlynmac for signing on macOS and upload signed binary from his repo to ours). | ||||||
- [ ] [Tag a release candidate](https://jamulus.io/contribute/Release-Process#steps-for-a-specific-release) (push the tag to [ann0see/jamulussign](https://github.com/ann0see/jamulussign/) for signing on macOS and upload signed binary to the official one). | ||||||
- [ ] Announce the release candidate on Github Discussions. Pin the thread. Unpin and lock the beta thread. | ||||||
- [ ] Draft an announcement, include all contributors via `tools/get_release_contributors.py` | ||||||
- [ ] [Update the Changelog](https://jamulus.io/contribute/Release-Process#updating-the-changelog) | ||||||
- [ ] [Tag the release version](https://jamulus.io/contribute/Release-Process#steps-for-a-specific-release): | ||||||
- [ ] Update the version number in `Jamulus.pro` and add the release date to the Changelog header and commit. | ||||||
- [ ] Wait for the release build to complete. | ||||||
- [ ] Contact emlynmac for signing on macOS and upload signed binary [from his](https://github.com/emlynmac/jamulus/releases/) repo [to ours](https://github.com/jamulussoftware/jamulus/releases). | ||||||
- [ ] Push the release to [ann0see/jamulussign](https://github.com/ann0see/jamulussign/) for macOS signing and upload signed binary [from the signing repo](https://github.com/ann0see/jamulussign/releases) repo [to the official one](https://github.com/jamulussoftware/jamulus/releases).. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- [ ] Do a smoke test for Windows/Mac/Linux -- Do the binaries start/connect properly? Can earlier Jamulus versions properly connect to a server based on the new release? | ||||||
- [ ] [Force tag that tag as `latest` and push.](https://jamulus.io/contribute/Release-Process#if-this-is-a-proper-release-move-the-latest-tag) | ||||||
- [ ] [Upload the artifacts to SourceForge and set defaults](https://jamulus.io/contribute/Release-Process#upload-binaries-to-sourceforge). | ||||||
|
@@ -321,7 +321,7 @@ Current state: <!-- Planning|Translations (beta)|Code freeze (rc)|Released --> | |||||
- [ ] On Github Discussions in the Announcements section. Lock the announcement thread. Pin the thread. Unpin and lock release candidate thread. | ||||||
- [ ] On Facebook in the group "Jamulus (official group)". Turn off replies. | ||||||
- [ ] Trigger the update notification by updating both Update Check Servers with the new version (@pljones for update02, email corrados for update01) | ||||||
- [ ] [Prepare `Jamulus.pro` (`dev` suffix) and ChangeLog (add a header) for the [next release](https://jamulus.io/contribute/Release-Process#make-the-main-branch-ready-for-post-release-development) | ||||||
- [ ] Prepare `Jamulus.pro` (`dev` suffix) and ChangeLog (add a header) for the [next release](https://jamulus.io/contribute/Release-Process#make-the-main-branch-ready-for-post-release-development) | ||||||
- [ ] Check that all Issues and PRs tagged for this release are in Done/Closed state. | ||||||
- [ ] Close the release milestone in both jamulus and jamuluswebsite repos | ||||||
- [ ] Create a milestone for the next minor release in jamulus and jamuluswebsite repos | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot.