Update signing procedure #1075
Draft
Update signing procedure #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
force-pushed
the
fixSigningMac
branch
from
172e2a9 to
25a14b0
Compare
|
Seems as if there's a syntax error in pt-BR? |
pljones
reviewed
Dec 23, 2024
| @@ -276,7 +276,7 @@ Current state: <!-- Planning|Translations (beta)|Code freeze (rc)|Released --> | |||
| - [ ] Agree to de-tag unfinished Issues/PRs. | |||
| - [ ] Declare a freeze for code and website by updating this Issue and adding a comment. PRs can still be worked on and may get reviewed, but must not be merged unless agreed explicitly. | |||
| - [ ] Check the `needs documentation` label for any outstanding PRs flagged for this release and remove that label if done. | |||
| - [ ] Check ./Jamulus -h output against the [Include-Client](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Client-Commands.md)/[Server-Commands](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Server-Commands.md).md pages and [man page (distributions/Jamulus.1)[(https://github.com/jamulussoftware/jamulus/blob/main/distributions/Jamulus.1). Update if necessary. | |||
| - [ ] Check ./Jamulus -h output against the [Include-Client](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Client-Commands.md)/[Server-Commands](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Server-Commands.md).md pages and [man page (distributions/Jamulus.1)](https://github.com/jamulussoftware/jamulus/blob/main/distributions/Jamulus.1). Update if necessary. | |||
pljones
approved these changes
Dec 23, 2024
|
Approved but I've a question -- is just pushing the tag enough? If your repo isn't already up to date, the tag will point to a non-existent (as yet) commit, so the build will fail. The "inform..." bit was to all emlynmac to pull from upstream and then pull the tags and push for his build. |
|
Not sure. I thought pushing a tag was enough: I did so in the past with a non existent commit on upstream. |
|
Interesting. Maybe github is clever enough to follow the upstream chain in the build. |
ann0see
commented
Jan 8, 2025
| - [ ] Announce the release candidate on Github Discussions. Pin the thread. Unpin and lock the beta thread. | ||
| - [ ] Draft an announcement, include all contributors via `tools/get_release_contributors.py` | ||
| - [ ] [Update the Changelog](https://jamulus.io/contribute/Release-Process#updating-the-changelog) | ||
| - [ ] [Tag the release version](https://jamulus.io/contribute/Release-Process#steps-for-a-specific-release): | ||
| - [ ] Update the version number in `Jamulus.pro` and add the release date to the Changelog header and commit. | ||
| - [ ] Wait for the release build to complete. | ||
| - [ ] Contact emlynmac for signing on macOS and upload signed binary [from his](https://github.com/emlynmac/jamulus/releases/) repo [to ours](https://github.com/jamulussoftware/jamulus/releases). | ||
| - [ ] Push the release to [ann0see/jamulussign](https://github.com/ann0see/jamulussign/) for macOS signing and upload signed binary [from the signing repo](https://github.com/ann0see/jamulussign/releases) repo [to the official one](https://github.com/jamulussoftware/jamulus/releases).. |
There was a problem hiding this comment.
Suggested change
| - [ ] Push the release to [ann0see/jamulussign](https://github.com/ann0see/jamulussign/) for macOS signing and upload signed binary [from the signing repo](https://github.com/ann0see/jamulussign/releases) repo [to the official one](https://github.com/jamulussoftware/jamulus/releases).. | |
| - [ ] Push the release to [ann0see/jamulussign](https://github.com/ann0see/jamulussign/) for macOS signing and upload signed binary [from the signing repo](https://github.com/ann0see/jamulussign/releases) repo [to the official one](https://github.com/jamulussoftware/jamulus/releases). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Updates the signing procedure to the new repo. Also fixes some broken markdown.
Context: Fixes an issue? Related issues
Fixes: #1046
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Review
Does this need translation?
No.
Checklist