fix(spec/votekeeper): Fix the VoteKeeper spec to account for skip threshold from higher round #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
commented
Nov 15, 2023
romac
commented
Nov 15, 2023
Base automatically changed from
hvanz/spec-votekeeper-pass
to
josef/executor
November 15, 2023 14:04
…eshold from higher round
…hich both prevoted and precommited
romac
force-pushed
the
romac/fix-vote-keeper-spec
branch
from
f187e3a to
f0bd9f9
Compare
hvanz
reviewed
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ancazamfir realized yesterday that the
VoteKeeperimplementation was not keeping track of the current round and therefore not emittingSkipthreshold from higher rounds.This PR attempts to fix the spec and is a companion to this PR which performs the corresponding change in the code: #73