fix(votekeeper): Compute threshold directly in VoteKeeper to account for Skip threshold
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## anca/keeper_skip_test #73 +/- ##
========================================================
Coverage ? 86.83%
========================================================
Files ? 27
Lines ? 1245
Branches ? 0
========================================================
Hits ? 1081
Misses ? 164
Partials ? 0 ☔ View full report in Codecov by Sentry. |
…t for `Skip` threshold
romac
force-pushed
the
romac/keeper-skip-future-2
branch
from
e8cd671 to
a6ed9e5
Compare
…d and precommited when checking for Skip threshold
romac
added a commit
that referenced
this pull request
Nov 22, 2023
…t for `Skip` threshold (#70) * Failing test for skip round * Fix expected_output and add test for skip with quorum * fix(votekeeper): Compute threshold directly in `VoteKeeper` to account for `Skip` threshold (#73) * fix(votekeeper): Compute threshold directly in `VoteKeeper` to account for `Skip` threshold * test: Re-enable VoteCount tests * test: Re-enable RoundVotes tests * test: Remove duplicate tests * test: Re-enable VoteKeeper tests * fix(votekeeper): Do not count validator weights twice if they prevoted and precommited when checking for Skip threshold * Fix skip tests --------- Co-authored-by: Anca Zamfir <anca@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding spec change in #74