fix: remove skip ci from workflow #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xeno097
approved these changes
Jan 7, 2025
ltyu
pushed a commit
that referenced
this pull request
Jan 7, 2025
### Description <!-- Summary of change. Example: Add sepolia chain --> When both combine or optimize-svg have changes, whoever finishes last would not be able to push because the other one already commited changes. I removed [skip ci] because it is not necessary and the initial thought was that it would loop but that should not be the case. Once one of the workflow updates it will trigger another check and if the other workflow has changes it will check again and do the proper changes. ### Backward compatibility <!-- Are these changes backward compatible? Note that additions are backwards compatible. Yes/No --> Yes ### Testing <!-- Have any new metadata configs and deployment addresses been used with any Hyperlane tooling, such as the CLI? --> Manual
ltyu
pushed a commit
that referenced
this pull request
Jan 8, 2025
### Description <!-- Summary of change. Example: Add sepolia chain --> When both combine or optimize-svg have changes, whoever finishes last would not be able to push because the other one already commited changes. I removed [skip ci] because it is not necessary and the initial thought was that it would loop but that should not be the case. Once one of the workflow updates it will trigger another check and if the other workflow has changes it will check again and do the proper changes. ### Backward compatibility <!-- Are these changes backward compatible? Note that additions are backwards compatible. Yes/No --> Yes ### Testing <!-- Have any new metadata configs and deployment addresses been used with any Hyperlane tooling, such as the CLI? --> Manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When both combine or optimize-svg have changes, whoever finishes last would not be able to push because the other one already commited changes. I removed [skip ci] because it is not necessary and the initial thought was that it would loop but that should not be the case. Once one of the workflow updates it will trigger another check and if the other workflow has changes it will check again and do the proper changes.
Backward compatibility
Yes
Testing
Manual