Skip to content

Commit

Permalink
fix: remove skip ci from workflow (#468)
Browse files Browse the repository at this point in the history
### Description

<!--
Summary of change.
Example: Add sepolia chain
-->

When both combine or optimize-svg have changes, whoever finishes last
would not be able to push because the other one already commited
changes. I removed [skip ci] because it is not necessary and the initial
thought was that it would loop but that should not be the case. Once one
of the workflow updates it will trigger another check and if the other
workflow has changes it will check again and do the proper changes.

### Backward compatibility

<!--
Are these changes backward compatible? Note that additions are backwards
compatible.

Yes/No
-->
Yes

### Testing

<!--
Have any new metadata configs and deployment addresses been used with
any Hyperlane tooling, such as the CLI?
-->
Manual
  • Loading branch information
Xaroz authored Jan 7, 2025
1 parent 6231a64 commit 6832724
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/combine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
CHANGES=$(git status -s)
if [[ ! -z $CHANGES ]]; then
git add .
git commit -m "Update chain metadata and address files [skip ci]"
git commit -m "Update chain metadata and address files"
git push
else
echo "No changes to commit."
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/optimize-svg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
CHANGES=$(git status -s)
if [[ ! -z $CHANGES ]]; then
git add .
git commit -m "Optimize SVG files [skip ci]"
git commit -m "Optimize SVG files"
git push
else
echo "No changes to commit."
Expand Down

0 comments on commit 6832724

Please sign in to comment.