-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): improve sidebar component #2569
Conversation
This PR is dependent on #2570 |
75ee972
to
b6c6cec
Compare
libs/design/src/molecules/sidebar/sidebar/sidebar.component.scss
Outdated
Show resolved
Hide resolved
libs/design/src/molecules/sidebar/sidebar-header/sidebar-header.component.ts
Show resolved
Hide resolved
libs/design/sidebar/examples/src/basic-sidebar/basic-sidebar.component.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation
- Indicate the optionality of sidebar header and footer in docs.
- Document class props of sidebar header
- Document usage of Sidebar nav in various contexts.
- Figure out the demo of the sidebar nav in different spots.
- Read docs a few a times.
- Add documentation about importing
BrowserAnimationsModule
orNoopAnimationsModule
to use sidebar - Add documentation of sidebar with anchor scrolling element within body
Bugs
- Right sidebar has a horizontal scroll bar in over/under
- Anchor scrolling on page doesn't work because height is set on
<daff-sidebar-viewport>
. Solution is to set height on<daff-sidebar-viewport>
only if sidebar is open and mode isunder
orover
API Considerations
- Remove button from header, add slots instead.
-
Replace title with an ngIf
Tests
- Test focusing code
Legibility
- Review the clarity of the updateAnimationState in the sidebar viewport
libs/design/src/molecules/sidebar/sidebar-viewport/sidebar-viewport.component.ts
Outdated
Show resolved
Hide resolved
039aefb
to
524aaa8
Compare
ea212b4
to
45759b8
Compare
d4464ea
to
615bd01
Compare
|
4ef7a3f
to
ddfcc8f
Compare
@damienwebdev I've updated In terms of showing the examples for |
ddfcc8f
to
3426c6e
Compare
a0eaf5a
to
492c732
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #277, #2554
What is the new behavior?
over
andunder
modes.closeSidebar()
method to header to link closing code to the close button.Does this PR introduce a breaking change?
Other information