Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Deprecate DaffBackdropComponent and move logic inside of DaffSidebarComponent #2566

Closed
xelaint opened this issue Sep 19, 2023 · 1 comment · Fixed by #2673
Closed
Assignees
Labels
feat a new feature, enhancement, or improvement p2 medium priority package: design @daffodil/design
Milestone

Comments

@xelaint
Copy link
Member

xelaint commented Sep 19, 2023

💡 Feature request

Feature Name

Deprecate DaffBackdropComponent and move logic inside of DaffSidebarComponent

The Desired Behavior

The backdrop component logic should be moved into the sidebar component. Backdrop doesn't need to be its own component as it probably will not be used anywhere else except the sidebar.

Your Use Case

As a developer, I'd like to clean up our design library.

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Sep 19, 2023
@xelaint xelaint self-assigned this Sep 19, 2023
@AnnieMi888 AnnieMi888 added the p2 medium priority label Nov 30, 2023
@xelaint
Copy link
Member Author

xelaint commented Dec 12, 2023

Dependent on #2569 to be completed first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat a new feature, enhancement, or improvement p2 medium priority package: design @daffodil/design
Projects
Development

Successfully merging a pull request may close this issue.

2 participants