Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add warning note about user provided credential configurations. #14113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/devsite-help/client-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ and `Google.Cloud.Translation.V2` libraries support builders as well, but with f

## Specifying credentials

**Important**: If you accept a credential configuration (credential JSON/File/Stream) from an external source

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there going to be another PR for adding the warning in the method's documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for authentication to Google Cloud, you must validate it before providing it to any Google API or library.
Providing an unvalidated credential configuration to Google APIs can compromise the security of your systems and data.
For more information, refer to
[Validate credential configurations from external sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).

The following properties are used for specifying and configuring which credentials a client
uses to authenticate and authorize requests. When no properties are set,
[application default credentials](https://cloud.google.com/docs/authentication/production#automatically) are used.
Expand Down
Loading