docs: Add warning note about user provided credential configurations. #14113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards b/389125232
amanda-tarafa
added
the
do not merge
|
FYI @sai-sunder-s @jskeet Not to be merged until confirmation |
| @@ -23,6 +23,12 @@ and `Google.Cloud.Translation.V2` libraries support builders as well, but with f | |||
|
|
|||
| ## Specifying credentials | |||
|
|
|||
| **Important**: If you accept a credential configuration (credential JSON/File/Stream) from an external source | |||
There was a problem hiding this comment.
is there going to be another PR for adding the warning in the method's documentation?
There was a problem hiding this comment.
Yes, but that's on https://github.com/googleapis/google-api-dotnet-client.
There was a problem hiding this comment.
For completion: googleapis/google-api-dotnet-client#2916
sai-sunder-s
approved these changes
Jan 17, 2025
jskeet
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards b/389125232