Fix Sharding logic with using notbefore of a certificate. #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to GoogleChrome/CertificateTransparency#6, a NotAfter validity field of a X509 Certificate should be used. The policy is as follows. For a certificate to be accepted by the Log that has a time range specified. The certificate’s ‘Not After’ validity field value must: Be at or after ‘Start’ and Be before ‘End’
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
- Coverage 71.78% 71.76% -0.03%
==========================================
Files 90 90
Lines 9862 9862
==========================================
- Hits 7079 7077 -2
- Misses 2286 2288 +2
Partials 497 497
Continue to review full report at Codecov.
|
Mercurrent
approved these changes
Feb 6, 2020
zorawar87
pushed a commit
to n-ct/certificate-transparency-go
that referenced
this pull request
Feb 15, 2020
According to GoogleChrome/CertificateTransparency#6, a NotAfter validity field of a X509 Certificate should be used. The policy is as follows. For a certificate to be accepted by the Log that has a time range specified. The certificate’s ‘Not After’ validity field value must: Be at or after ‘Start’ and Be before ‘End’
zorawar87
pushed a commit
to n-ct/certificate-transparency-go
that referenced
this pull request
Feb 26, 2020
According to GoogleChrome/CertificateTransparency#6, a NotAfter validity field of a X509 Certificate should be used. The policy is as follows. For a certificate to be accepted by the Log that has a time range specified. The certificate’s ‘Not After’ validity field value must: Be at or after ‘Start’ and Be before ‘End’
zorawar87
pushed a commit
to n-ct/certificate-transparency-go
that referenced
this pull request
Mar 1, 2020
According to GoogleChrome/CertificateTransparency#6, a NotAfter validity field of a X509 Certificate should be used. The policy is as follows. For a certificate to be accepted by the Log that has a time range specified. The certificate’s ‘Not After’ validity field value must: Be at or after ‘Start’ and Be before ‘End’
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to GoogleChrome/CertificateTransparency#6, a NotAfter
validity field of a X509 Certificate should be used.
The policy is as follows.
For a certificate to be accepted by the Log that has a time range
specified.
The certificate’s ‘Not After’ validity field value must:
Be at or after ‘Start’ and Be before ‘End’
fixes #647
Checklist