Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect sharding logic for logs by using notBefore field. #648

Closed
eccopark opened this issue Feb 6, 2020 · 1 comment
Closed

Incorrect sharding logic for logs by using notBefore field. #648

eccopark opened this issue Feb 6, 2020 · 1 comment
Assignees
@Mercurrent @eccopark
Labels
bug

Comments

@eccopark
Copy link
Contributor

eccopark commented Feb 6, 2020

TemporallyCompatible function in logfiter.go currently uses the NotBefore field to check if the log is allowed to accept the certificate.
By the design, it should use notAfter field of a certificate.
@RJPercival RJPercival changed the title Incorrect sharing logic for logs by using notBefore field. Incorrect sharding logic for logs by using notBefore field. Feb 6, 2020
@RJPercival RJPercival added the bug label Feb 6, 2020
@jdkasten
Copy link

I think this was fixed via PR #647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mercurrent Mercurrent

@eccopark eccopark

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pphaneuf @Mercurrent @jdkasten @RJPercival @eccopark