Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

407 make validate arguments decorator required #408

Merged
merged 8 commits into from
Jun 8, 2023

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Jun 8, 2023

Include pydantic.decorator.validate_arguments for all tasks (close #407)

Note that in previous version the coercion&validation was optional, and deferred to the run_fractal_task function in tasks._utils module.

tcompa added 2 commits June 8, 2023 12:07
…407)

Note that in previous version the coercion&validation was optional, and deferred to the `run_fractal_task` function in `tasks._utils` module.
@tcompa tcompa linked an issue Jun 8, 2023 that may be closed by this pull request
@tcompa tcompa marked this pull request as ready for review June 8, 2023 10:17
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Coverage report

The coverage rate went from 81.46% to 82.67% ⬆️
The branch rate is 76%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

fractal_tasks_core/tasks/yokogawa_to_ome_zarr.py

100% of new lines are covered (84.54% of the complete file).

fractal_tasks_core/tasks/create_ome_zarr_multiplex.py

100% of new lines are covered (86.92% of the complete file).

fractal_tasks_core/tasks/_utils.py

100% of new lines are covered (77.77% of the complete file).

fractal_tasks_core/tasks/cellpose_segmentation.py

100% of new lines are covered (82% of the complete file).

fractal_tasks_core/tasks/copy_ome_zarr.py

100% of new lines are covered (89.52% of the complete file).

fractal_tasks_core/tasks/maximum_intensity_projection.py

100% of new lines are covered (86.15% of the complete file).

fractal_tasks_core/tasks/illumination_correction.py

100% of new lines are covered (77.03% of the complete file).

fractal_tasks_core/tasks/create_ome_zarr.py

100% of new lines are covered (82.9% of the complete file).

fractal_tasks_core/tasks/napari_workflows_wrapper.py

100% of new lines are covered (88.35% of the complete file).

@tcompa tcompa merged commit b359457 into main Jun 8, 2023
@tcompa tcompa deleted the 407-make-validate_arguments-decorator-required branch June 8, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make validate_arguments decorator required
1 participant