Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make validate_arguments decorator required #407

Closed
tcompa opened this issue Jun 8, 2023 · 0 comments · Fixed by #408
Closed

Make validate_arguments decorator required #407

tcompa opened this issue Jun 8, 2023 · 0 comments · Fixed by #408
Labels
High Priority Current Priorities & Blocking Issues

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jun 8, 2023 •
edited
Loading

Ref #386 (comment)

Since we are now saying that pydantic may become an actual dependency, we can switch from an optional coerce_and_validate=True/False (which is currently part of the fractal_tasks_core.tasks._utils.run_fractal_task function) to always coerce&validate arguments of tasks.
@tcompa tcompa added the High Priority Current Priorities & Blocking Issues label Jun 8, 2023
tcompa added a commit that referenced this issue Jun 8, 2023
@tcompa
Include pydantic.decorator.validate_arguments for all tasks (close #…
811919e 
…407)

Note that in previous version the coercion&validation was optional, and deferred to the `run_fractal_task` function in `tasks._utils` module.
@tcompa tcompa linked a pull request Jun 8, 2023 that will close this issue
407 make validate arguments decorator required #408
Merged
@tcompa tcompa mentioned this issue Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
High Priority Current Priorities & Blocking Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

407 make validate arguments decorator required fractal-analytics-platform/fractal-tasks-core
1 participant
@tcompa