Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scalar functions Slug and Ascii #1337

Merged

Conversation

norberttech
Copy link
Member

Change Log

Added

  • Slug Scalar Function
  • Ascii Scalar Function

Fixed

Changed

Removed

Deprecated

Security


Description

Related to: #1316

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.750mb +0.02%  | 509.780ms -0.67% | ±0.34% +65.23%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.858mb +0.02%  | 1.111s +3.02%    | ±2.52% +456.99% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.494mb +0.00% | 907.671ms +0.69% | ±1.26% +277.85% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.483mb +0.02%  | 32.573ms +1.09%  | ±1.14% +35.89%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.459mb +0.02%  | 660.819ms -1.39% | ±0.58% +25.57%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 108.479mb +0.00% | 58.052ms -0.24% | ±0.91% -36.92% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.024mb +0.00%  | 115.777ms +1.46% | ±1.11% +24.17%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 82.570mb +0.00%  | 107.956ms -1.31% | ±1.22% -50.44%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.990mb +0.00% | 19.315s -0.52%   | ±0.45% +397.91% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.067mb +0.01%  | 43.741ms -0.71%  | ±0.73% -56.09%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 80.254mb +0.00%  | 3.187ms -14.60%  | ±0.83% -69.86%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 97.528mb +0.00%  | 178.411ms -1.35% | ±0.86% -65.72%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 80.248mb +0.00%  | 17.963ms -2.26%  | ±0.40% -37.30%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 81.129mb +0.00%  | 1.514ms -12.65%  | ±3.76% +18.64%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 81.129mb +0.00%  | 1.575ms -12.15%  | ±3.24% +1.84%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 79.290mb +0.00%  | 3.409ms -9.06%   | ±2.38% +33.66%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 79.819mb +0.00%  | 15.018ms +1.32%  | ±2.79% +219.08% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 79.819mb +0.00%  | 15.126ms +1.07%  | ±0.84% -32.96%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 78.510mb +0.00%  | 1.794μs -10.30%  | ±2.67% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 78.510mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.847mb +0.00%  | 12.669ms -2.61%  | ±0.81% -54.75%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 114.195mb +0.00% | 58.839ms -1.00%  | ±0.68% +0.85%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 80.339mb +0.00%  | 1.469ms -10.36%  | ±1.90% +167.19% |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 83.628mb +0.00%  | 61.111ms -1.03%  | ±0.45% -81.14%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 81.391mb +0.00%  | 3.912ms -3.00%   | ±2.02% -31.13%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 78.790mb +0.00%  | 40.740ms -4.43%  | ±0.37% -74.97%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 78.790mb +0.00%  | 41.666ms -3.44%  | ±2.50% +803.87% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 78.790mb +0.00%  | 41.311ms -2.43%  | ±0.31% -44.61%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 80.951mb +0.00%  | 7.812ms +1.09%   | ±0.47% -77.91%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 78.701mb +0.00%  | 30.301ms +1.78%  | ±0.57% +6.48%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 78.510mb +0.00%  | 13.967μs -2.37%  | ±2.97% +35.83%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 78.510mb +0.00%  | 15.938μs +3.21%  | ±2.45% +16.19%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 97.529mb +0.00%  | 184.179ms -1.45% | ±1.93% +342.70% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 49.236mb +0.00%  | 382.605ms -0.52% | ±0.97% +334.71% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 12.803mb +0.01%  | 77.801ms +0.62%  | ±0.56% +61.77%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 103.312mb +0.00% | 465.191ms +0.20% | ±0.39% -50.62%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 53.823mb +0.00%  | 234.531ms +0.68% | ±3.17% +501.11% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.401mb +0.01%  | 52.455ms +0.95%  | ±0.96% -26.68%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.57%. Comparing base (cde543f) to head (dd13a31).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1337      +/-   ##
==========================================
+ Coverage   82.55%   82.57%   +0.02%     
==========================================
  Files         643      645       +2     
  Lines       17428    17449      +21     
==========================================
+ Hits        14387    14408      +21     
  Misses       3041     3041              
Components Coverage Δ
etl 85.88% <100.00%> (+0.04%) ⬆️
cli 85.17% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.60% <ø> (ø)
lib-doctrine-dbal-bulk 97.36% <ø> (ø)
lib-filesystem 76.24% <ø> (ø)
lib-parquet 84.16% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-rdsl 87.09% <ø> (ø)
lib-snappy 90.78% <ø> (ø)
bridge-filesystem-async-aws 90.60% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 77.10% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 90.14% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 92.85% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.80% <ø> (ø)
adapter-parquet 60.74% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)

@norberttech norberttech merged commit fc8898f into flow-php:1.x Jan 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant