-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with symfony/string for better strings manipulation #1316
Comments
How does it differ from Symfony String? |
Interesting, I would need to go through entire APIs of both libs to understand which one provides more value. So the question is what makes more sense, portable-ascii + portable-utf8 or symfony/string? |
I asked GitHub copilot which one we should use and he said symfony/string but without any good justification 😅 I wouldn't trust it, comparing the APIs - that's what we |
https://symfony.com/doc/current/string.html#methods-to-change-case just noticed that symfony/string can also replace an existing case converting dependency. |
This is an example of how easy it is to create Scalar Functions: #1337 |
That would be very helpful integration from text processing point of view.
Library: https://github.com/symfony/string
It should be pretty straightforward since we would just need to create a scalar function for each of the methods string methods.
I think we can make it a part of TextAdapter, just put all scalar functions inside of it.
All those functions should be also added to TextAdapter DSL functions, with a text_ prefix.Those functions should exist in the
src/core/etl/src/Flow/ETL/Function
namespace and be part of the core ETL.We don't even need to create for them dedicated DSL functions (as they can only operate on string), what we can do is simply expose them through
src/core/etl/src/Flow/ETL/Function/ScalarFunctionChain.php
so they would all be available throughref()->xxxx
Documentation: How to create scalar function
The text was updated successfully, but these errors were encountered: