Support _one of_ for required tasks #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created as draft, support for the pipeline rules needs to be added. |
lcarva
approved these changes
Nov 1, 2023
| } | ||
|
|
||
| _any_missing(required, tasks) := missing if { | ||
| # one of required tasks is required | ||
| is_array(required) |
There was a problem hiding this comment.
Could use a helper method to avoid having to implement the logic for both cases, e.g.
_any_missing(required, tasks) := missing if {
req := setfy(required)
tsk := setfy(tasks)
...
}
setfy(o) := s if {
s := {v | some v in o}
} else := {o}This could maybe reside in policy/lib/set_helpers.rego.
There was a problem hiding this comment.
Turns out we already have that helper there :)
There was a problem hiding this comment.
I think it would've been nice to unify the two use cases (array vs non-array) which is what I was trying to drive at with this comment. But anyways, the current approach works just as well 😉
zregvart
force-pushed
the
issue/RHTAPBUGS-914
branch
from
0f030b0 to
b3ae211
Compare
Codecov Report
@@ Coverage Diff @@
## main #789 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 3342 3425 +83
=========================================
+ Hits 3342 3425 +83
|
This adds support for the notion of _one of_ required tasks from the required tasks list. For example, given required tasks data as: ```yaml - A - [B, C, D] - E ``` Tasks "A", at least one of "B", "C" or "D", and "E" are required.
zregvart
force-pushed
the
issue/RHTAPBUGS-914
branch
from
b3ae211 to
d4e9abf
Compare
zregvart
added a commit
to zregvart/rhtap-ec-policy
that referenced
this pull request
Nov 2, 2023
With the enterprise-contract/ec-policies#789 merged we can support 'one of' semantic in required task. This changes the definition of required tasks so one of buildah task variants is required. reference: https://issues.redhat.com/browse/RHTAPBUGS-914
|
Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the notion of one of required tasks from the required tasks list.
For example, given required tasks data as:
Tasks "A", at least one of "B", "C" or "D", and "E" are required.