Add all variants of buildah task #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the enterprise-contract/ec-policies#789 merged we can support 'one of' semantic in required task. This changes the definition of required tasks so one of buildah task variants is required. reference: https://issues.redhat.com/browse/RHTAPBUGS-914
|
I'm not sure if any of the other pipelines need to require the buildah* task. |
|
This can't be merged until we know that enterprise-contract/ec-policies#789 is running in production |
|
I see that PR is merged, so is this ok to merge now? Or are we still waiting for confirmation? |
|
Last use of a policy version not containing support for this was at 2023-11-03 10:34:57.341 (UTC). I think this is now safe to merge. |
|
@rhartman93 when you get a chance can you merge this? |
lcarva
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the enterprise-contract/ec-policies#789 merged we can support 'one of' semantic in required task. This changes the definition of required tasks so one of buildah task variants is required.
reference: https://issues.redhat.com/browse/RHTAPBUGS-914