Allow to seek a voice message before playing it

[julioromano]

Previously the only way to start interacting with a voice message was to play it. This change makes it possible to start interacting also with a seek.

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/1WcgH1

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c25e69) 63.34% compared to head (d97bc3c) 63.34%.
Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1780   +/-   ##
========================================
  Coverage    63.34%   63.34%           
========================================
  Files         1290     1290           
  Lines        33502    33505    +3     
  Branches      6962     6962           
========================================
+ Hits         21221    21224    +3     
  Misses        9107     9107           
  Partials      3174     3174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonnyandrew]

Code looks good!

Just a few issues I noticed while testing which may or may not be related to the changes:

• The progress bar flickers down on first seeking. This video shows it but you may need to play it frame by frame to see:

Screencast.from.10-11-23.11.32.21.webm

• After clearing the app cache to test, I couldn't play any voice messages:

Screencast.from.10-11-23.11.40.57.webm

[julioromano]

• After clearing the app cache to test, I couldn't play any voice messages:

Could you please double check this after the latest rebase? I've just cleared the cache dir twice and this didn't happen.

[jonnyandrew]

I just tested and can still reproduce at 1682b0b but actually, I can also repro on develop so I don't think it should block this PR.

I raised a separate bug about it with steps to reproduce: #1788

[julioromano]

I just tested and can still reproduce at 1682b0b but actually, I can also repro on develop so I don't think it should block this PR.

I raised a separate bug about it with steps to reproduce: #1788

After seeing exactly what you do in the video I can reproduce.

[julioromano]

• The progress bar flickers down on first seeking. This video shows it but you may need to play it frame by frame to see:

This is because the call to VoiceMessagePlayer.seekTo() is suspend due to MediaPlayer.setMedia() being suspend in turn.
We must wait for the media player to be ready before we can call seek on it so that it actually updates the player progress.
In the time until the player is ready the progress will still show 0 hence the flicker.
If you insert an artificial delay in the first line of MediaPlayer.setMedia() you can see this glitch even more prominently.

[julioromano]

@jonnyandrew waiting to merge this because I'd like #1795 to land before it.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information