Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Scrub the playback position of a voice message #2113

Closed
4 of 13 tasks
Tracked by #2081
jonnyandrew opened this issue Oct 5, 2023 · 0 comments
Closed
4 of 13 tasks
Tracked by #2081

[Story] Scrub the playback position of a voice message #2113

jonnyandrew opened this issue Oct 5, 2023 · 0 comments

Comments

@jonnyandrew
Copy link

jonnyandrew commented Oct 5, 2023

Description

  • As a user
  • I want to scrub the playback position of a voice message
  • So that I can quickly rewind or skip to a different playback position

Acceptance criteria

  • Playback position indicator displays when playing or paused
  • Tapping the player moves the playback position
  • Works in the timeline for received messages
  • Works in the preview player for recorded messages

Detailed green cursor (a.k.a 'scrubber') behaviour

  • The cursor does not display initially.
  • If the cursor is not already displayed:
    • dragging the waveform does not make the cursor appear;
    • tapping the waveform does make the cursor appear; and
    • playing the voice message does make the cursor appear.
  • Once the voice message finishes playing, the cursor disappears.
  • Dragging a visible cursor moves it. The touch target is accurate to just the area around the cursor.
  • Tapping the waveform moves the cursor to different parts of the recording.
  • Once the scrubber is displayed, it continues to display even when other voice messages are played.
  • Hence, showing multiple scrubbers on different voice messages is okay.
  • And as multiple cursors can show, they can all be dragged.
  • If another voice message is played, the position of the cursors on other paused voice messages is maintained.

Size estimate

None

Dependencies

Preconditions

No response

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

Out of scope

No response

Open questions

No response

Subtasks

Android

Preview Give feedback
  1. julioromano
  2. julioromano
  3. julioromano

iOS

Preview Give feedback
  1. nimau

Other

Preview Give feedback
No tasks being tracked yet.
@nimau nimau self-assigned this Oct 12, 2023
@julioromano julioromano self-assigned this Nov 14, 2023
julioromano pushed a commit to element-hq/element-x-android that referenced this issue Nov 21, 2023
- Voice messages can be scrubbed (i.e. seeked to) even when they have not been played yet..
- The progress bar is displayed also when paused.
- Multiple voice messages can keep their state when paused.
- Tries to adhere as much as possible at the detailed "green cursor" behavior in the story (but might not be 100% compliant).

Story: element-hq/element-meta#2113
julioromano pushed a commit to element-hq/element-x-android that referenced this issue Nov 21, 2023
- Voice messages can be scrubbed (i.e. seeked to) even when they have not been played yet..
- The progress bar is displayed also when paused.
- Multiple voice messages can keep their state when paused.
- Tries to adhere as much as possible at the detailed "green cursor" behavior in the story (but might not be 100% compliant).

Story: element-hq/element-meta#2113
@julioromano julioromano removed their assignment Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants