-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time to voice message composer UI #1720
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
fbc6446
to
ffa0900
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1720 +/- ##
========================================
Coverage 63.45% 63.46%
========================================
Files 1282 1282
Lines 33274 33286 +12
Branches 6885 6885
========================================
+ Hits 21115 21125 +10
- Misses 8976 8977 +1
- Partials 3183 3184 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe the data used for the previews could be improved for more coherency?
...s/ui_S_t[l.textcomposer.components_null_VoiceMessagePreview-D-16_16_null,NEXUS_5,1.0,en].png
Show resolved
Hide resolved
...snapshots/images/ui_S_t[l.textcomposer_null_TextComposerVoice-N-4_5_null,NEXUS_5,1.0,en].png
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Type of change
Content
Add time to voice message composer UI.
Known issue: the time does not display the duration of the voice recording until it has been played at least once.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist