Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time to voice message composer UI #1720

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Nov 1, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add time to voice message composer UI.

Known issue: the time does not display the duration of the voice recording until it has been played at least once.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner November 1, 2023 15:41
@jonnyandrew jonnyandrew requested review from bmarty and removed request for a team November 1, 2023 15:41
Copy link
Contributor

github-actions bot commented Nov 1, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/p16xuy

@jonnyandrew jonnyandrew force-pushed the jonny/vm-composer-time branch from fbc6446 to ffa0900 Compare November 1, 2023 20:46
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f5c617) 63.45% compared to head (358f687) 63.46%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1720   +/-   ##
========================================
  Coverage    63.45%   63.46%           
========================================
  Files         1282     1282           
  Lines        33274    33286   +12     
  Branches      6885     6885           
========================================
+ Hits         21115    21125   +10     
- Misses        8976     8977    +1     
- Partials      3183     3184    +1     
Files Coverage Δ
...icemessages/composer/VoiceMessageComposerPlayer.kt 72.72% <100.00%> (+2.72%) ⬆️
...messages/composer/VoiceMessageComposerPresenter.kt 94.20% <100.00%> (+0.08%) ⬆️
...ent/android/libraries/textcomposer/TextComposer.kt 77.68% <100.00%> (+0.06%) ⬆️
...ies/textcomposer/components/VoiceMessagePreview.kt 74.32% <100.00%> (-0.68%) ⬇️
.../libraries/textcomposer/model/VoiceMessageState.kt 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe the data used for the previews could be improved for more coherency?

@jonnyandrew jonnyandrew enabled auto-merge (squash) November 2, 2023 11:59
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew merged commit 83a6395 into develop Nov 2, 2023
14 checks passed
@jonnyandrew jonnyandrew deleted the jonny/vm-composer-time branch November 2, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants