Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display duration of recorded voice message #1733

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Nov 2, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Measure and display the duration of a voice message in the UI, ensuring that it continues to be displayed even when a different media player is focused.

Motivation and context

Part of element-hq/element-meta#2113 and element-hq/element-meta#2104

Screenshots / GIFs

Tests

  • Record and play back a voice message
  • Pause the recorded voice message
  • Play a voice message in the timeline
  • Repeat the above in different order

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew changed the title Display duration of voice message in UI Display duration of recorded voice message Nov 2, 2023
@jonnyandrew jonnyandrew marked this pull request as ready for review November 2, 2023 17:31
@jonnyandrew jonnyandrew requested a review from a team as a code owner November 2, 2023 17:31
@jonnyandrew jonnyandrew requested review from julioromano and removed request for a team November 2, 2023 17:31
Copy link
Contributor

github-actions bot commented Nov 2, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wo7wUT

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1f5a135) 63.48% compared to head (bde207b) 63.48%.
Report is 1 commits behind head on develop.

❗ Current head bde207b differs from pull request most recent head 225d989. Consider uploading reports for the commit 225d989 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1733   +/-   ##
========================================
  Coverage    63.48%   63.48%           
========================================
  Files         1285     1282    -3     
  Lines        33359    33311   -48     
  Branches      6906     6891   -15     
========================================
- Hits         21177    21148   -29     
+ Misses        8987     8976   -11     
+ Partials      3195     3187    -8     
Files Coverage Δ
...ent/android/libraries/textcomposer/TextComposer.kt 77.50% <100.00%> (+0.06%) ⬆️
...ies/textcomposer/components/VoiceMessagePreview.kt 74.32% <100.00%> (ø)
.../libraries/textcomposer/model/VoiceMessageState.kt 100.00% <100.00%> (ø)
.../libraries/voicerecorder/api/VoiceRecorderState.kt 100.00% <100.00%> (ø)
.../libraries/voicerecorder/test/FakeVoiceRecorder.kt 92.50% <100.00%> (+0.19%) ⬆️
...icemessages/composer/VoiceMessageComposerPlayer.kt 73.52% <66.66%> (+0.80%) ⬆️
...messages/composer/VoiceMessageComposerPresenter.kt 92.10% <81.81%> (-2.10%) ⬇️
.../libraries/voicerecorder/impl/VoiceRecorderImpl.kt 91.30% <71.42%> (-2.73%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew enabled auto-merge (squash) November 3, 2023 12:38
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew merged commit ddc1e1d into develop Nov 3, 2023
12 checks passed
@jonnyandrew jonnyandrew deleted the jonny/vm-composer-time-init branch November 3, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants