Do external package manager check only at startup #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
added
enhancement
We were doing the check for external package manager use when validating vars for the platform, which happens on every configuration reload. I've made this an attribute of the platform instead, and it's now only checked on startup.
swiatekm
force-pushed
the
fix/dont-check-pkgmgr-on-config-reload
branch
from
a95566c to
204a1a6
Compare
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
kaanyalti
approved these changes
Dec 5, 2024
blakerouse
approved these changes
Dec 9, 2024
Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Do external package manager check only at startup We were doing the check for external package manager use when validating vars for the platform, which happens on every configuration reload. I've made this an attribute of the platform instead, and it's now only checked on startup. * Update changelog/fragments/1733131399-vars-for-platform.yaml Co-authored-by: Blake Rouse <blake.rouse@elastic.co> --------- Co-authored-by: Blake Rouse <blake.rouse@elastic.co> (cherry picked from commit af175e0)
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Do external package manager check only at startup We were doing the check for external package manager use when validating vars for the platform, which happens on every configuration reload. I've made this an attribute of the platform instead, and it's now only checked on startup. * Update changelog/fragments/1733131399-vars-for-platform.yaml Co-authored-by: Blake Rouse <blake.rouse@elastic.co> --------- Co-authored-by: Blake Rouse <blake.rouse@elastic.co> (cherry picked from commit af175e0)
This was referenced Dec 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Do external package manager check only at startup We were doing the check for external package manager use when validating vars for the platform, which happens on every configuration reload. I've made this an attribute of the platform instead, and it's now only checked on startup. * Update changelog/fragments/1733131399-vars-for-platform.yaml Co-authored-by: Blake Rouse <blake.rouse@elastic.co> --------- Co-authored-by: Blake Rouse <blake.rouse@elastic.co> (cherry picked from commit af175e0)
4 tasks
swiatekm
added a commit
that referenced
this pull request
Dec 10, 2024
* Do external package manager check only at startup We were doing the check for external package manager use when validating vars for the platform, which happens on every configuration reload. I've made this an attribute of the platform instead, and it's now only checked on startup. * Update changelog/fragments/1733131399-vars-for-platform.yaml Co-authored-by: Blake Rouse <blake.rouse@elastic.co> --------- Co-authored-by: Blake Rouse <blake.rouse@elastic.co> (cherry picked from commit af175e0) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm
added a commit
that referenced
this pull request
Dec 10, 2024
* Do external package manager check only at startup We were doing the check for external package manager use when validating vars for the platform, which happens on every configuration reload. I've made this an attribute of the platform instead, and it's now only checked on startup. * Update changelog/fragments/1733131399-vars-for-platform.yaml Co-authored-by: Blake Rouse <blake.rouse@elastic.co> --------- Co-authored-by: Blake Rouse <blake.rouse@elastic.co> (cherry picked from commit af175e0) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
ycombinator
pushed a commit
that referenced
this pull request
Dec 12, 2024
* Do external package manager check only at startup We were doing the check for external package manager use when validating vars for the platform, which happens on every configuration reload. I've made this an attribute of the platform instead, and it's now only checked on startup. * Update changelog/fragments/1733131399-vars-for-platform.yaml Co-authored-by: Blake Rouse <blake.rouse@elastic.co> --------- Co-authored-by: Blake Rouse <blake.rouse@elastic.co> (cherry picked from commit af175e0) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We were doing the check for external package manager use when validating vars for the platform, which happens on every configuration reload. I've made this an attribute of the platform instead, and it's now only checked on startup.
Why is it important?
Reading a bunch of files every time configuration is reloaded is an unnecessary expense.
Checklist
./changelog/fragmentsusing the changelog toolRelated issues