Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #6178) Do external package manager check only at startup #6253

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 9, 2024

What does this PR do?

We were doing the check for external package manager use when validating vars for the platform, which happens on every configuration reload. I've made this an attribute of the platform instead, and it's now only checked on startup.

Why is it important?

Reading a bunch of files every time configuration is reloaded is an unnecessary expense.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues


This is an automatic backport of pull request #6178 done by [Mergify](https://mergify.com).

* Do external package manager check only at startup

We were doing the check for external package manager use when validating
vars for the platform, which happens on every configuration reload. I've
made this an attribute of the platform instead, and it's now only
checked on startup.

* Update changelog/fragments/1733131399-vars-for-platform.yaml

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>

---------

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
(cherry picked from commit af175e0)
@mergify mergify bot requested a review from a team as a code owner December 9, 2024 18:06
@mergify mergify bot added the backport label Dec 9, 2024
@mergify mergify bot requested review from michel-laterman and swiatekm and removed request for a team December 9, 2024 18:06
Copy link

@swiatekm swiatekm merged commit d039a51 into 8.16 Dec 10, 2024
15 checks passed
@swiatekm swiatekm deleted the mergify/bp/8.16/pr-6178 branch December 10, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant