Sync DAP interfaces and types with DAP 1.69.x spec #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansorg
force-pushed
the
dap-spec-sync
branch
5 times, most recently
from
3b031ef to
b51afd4
Compare
jansorg
force-pushed
the
dap-spec-sync
branch
2 times, most recently
from
b28b343 to
17165d0
Compare
…tion to declarations, and a corresponding locations request.
…om debug adapters.
jonahgraham
force-pushed
the
dap-spec-sync
branch
from
4eac9b4 to
ac74e5b
Compare
jonahgraham
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Thanks @jansorg for doing all the heavy lifting here on bringing this up to 1.69.
I added a few additional documentation changes and the missing supportsDataBreakpointBytes in Capabilities.
Can you have a look at the changes I just pushed to ensure that I didn't undo anything you intentionally did.
Thanks again!
|
@jonahgraham Thanks for the review! Your changes seem fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #862
This syncs LSP4J's data types and interfaces with the latest version of the DAP specification, version 1.69.
I kept the commit messages the same as the items in the DAP changelog at https://microsoft.github.io/debug-adapter-protocol/changelog