DAP: Variable.declarationLocationReference and Variable.valueLocationReference are missing

[jansorg]

The DAP spec defines properties declarationLocationReference and valueLocationReference for type Variable.
https://microsoft.github.io/debug-adapter-protocol//specification.html#Types_Variable

But LSP4J's Variable does not define these properties.

[jonahgraham]

Hi, @jansorg - the current LSP4J DAP implementation needs updating, it currently on 1.65, but the latest spec is 1.69 and the locationReferences are a new feature in 1.68.

I will look at adding the new versions soon to LSP4J, but not sure exactly when. Contributions are welcome and if you can get a PR in I will prioritize that sooner.

[jansorg]

@jonahgraham Thanks!
I tried to find out where the properties are defined, but was unable to find it. They seem to be autogenerated.
Do you mind to point me where I'd have to update the properties? Then I'll try to make this happen.

[cdietrich]

lsp4j/org.eclipse.lsp4j.debug/src/main/java/org/eclipse/lsp4j/debug/DebugProtocol.xtend

Line 3342 in fea59ba

class Variable {

[jansorg]

#863 should sync the current DAP implementation with the latest spec.
I'll fix the Eclipse ECA thing tomorrow...

[jansorg]

@jonahgraham I've finished the pull request to sync with the DAP 1.69 spec. I'd appreciate if this was shipped with the next release.
I'm not sure why the ECA is still shown as unavailable, I've signed it and the GitHub Actions check seemed to be successful.

[jonahgraham]

@jonahgraham I've finished the pull request to sync with the DAP 1.69 spec.

Wonderful, thanks for doing that work. I will review it and, if ready, will merge soon...

I'd appreciate if this was shipped with the next release.

... once merged it will be in snapshots on maven central. We haven't discussed a next release date, but if you have input on when it would mesh well with your schedule can you comment on #834

[jonahgraham]

once merged it will be in snapshots on maven central

0.24.0-SNAPSHOT should now include this change. LMK if you see anything awry.