Add tests #224
Closed
Add tests #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for some reason getRecurInfo() is nested within run() which prevents the page from being loaded twice (since getRecurInfo is defined twice).
Specifically adding api call to setup a test PP.
this will make it easier to selectively replay
h-c-c
reviewed
Jun 30, 2017
|
When testing, passive Webhooks simply don't work (we can't get Stripe to ping a development machine). So, after the test recurring contribution is made, we have to actively query Stripe to find the single exact event that was triggered by the recurring contribution so we can process that event through the Webhook code. To do so, we query all events on Stripe that happened after the recurring contribution was made. In probably 99.999% of cases there will be only one event (since this is a matter of seconds), however, to be safe we check the subscription id generated by the contribution so we are 100% sure we are processing the Stripe Event that was triggered by the given contribution. |
|
Closing in favor of #242 (now refactored against 4.7-dev) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #223
This pull requests makes minor changes to the production code in order to facilitate the tests - so it should not have much impact on current installations.
However, it does add a lot of testing and api code which will help as we refactor and add new features moving forward.