-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe should support handlePaymentNotification #221
Comments
Aside from the obvious difference in URL, how is how is this functionally different from the multiple Stripe account support that @agh1 contributed? To my knowledge, none of the challenges surrounding multiple Stripe accounts have to do with the webhook code at this time. |
Functionally it's the same, however, by supporting handlePaymentNotification we will provide support for the new standard way to distinguish between payment processors - so if users follow the general CiviCRM directions it will work with Stripe. Additionally, CiviCRM has an IPN base class. To keep up with CiviCRM Core development, we should probably implement that Base class rather than handle web hooks via a class the extends CRM_Core_Page |
And create unit tests to ensure that our IPN code continues to work. I'm happy to work on this ticket. |
I've created unit tests via #224 |
This allows use of webhook in format /civicrm/payment/ipn/N drastik#221
Tests are created - and this pull requests does it all: #225 and passes all tests. Note: this has no impact by default - it will only be used if people switch to the standard CiviCRM IPN handling URL (civicrm/payment/ipn/N). |
This allows use of webhook in format /civicrm/payment/ipn/N drastik#221
This allows use of webhook in format /civicrm/payment/ipn/N drastik#221
This allows use of webhook in format /civicrm/payment/ipn/N drastik#221
… CiviCRM. Look for contribution using subscription_id for future recurring start date
In 4.7, CiviCRM payment processors that have a handlePaymentNotification method can have their webhooks accessed via /civicrm/payment/ipn/ID - where ID is the payment processor id.
This allows us to properly handle payments from two different Stripe payment processors configured on the site, which is not possible now.
The text was updated successfully, but these errors were encountered: