Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe should support handlePaymentNotification #221

Open
jmcclelland opened this issue Jun 23, 2017 · 5 comments
Open

Stripe should support handlePaymentNotification #221

jmcclelland opened this issue Jun 23, 2017 · 5 comments

Comments

@jmcclelland
Copy link
Contributor

In 4.7, CiviCRM payment processors that have a handlePaymentNotification method can have their webhooks accessed via /civicrm/payment/ipn/ID - where ID is the payment processor id.

This allows us to properly handle payments from two different Stripe payment processors configured on the site, which is not possible now.

@h-c-c
Copy link
Collaborator

h-c-c commented Jun 23, 2017

Aside from the obvious difference in URL, how is how is this functionally different from the multiple Stripe account support that @agh1 contributed?

To my knowledge, none of the challenges surrounding multiple Stripe accounts have to do with the webhook code at this time.

@jmcclelland
Copy link
Contributor Author

Functionally it's the same, however, by supporting handlePaymentNotification we will provide support for the new standard way to distinguish between payment processors - so if users follow the general CiviCRM directions it will work with Stripe.

Additionally, CiviCRM has an IPN base class. To keep up with CiviCRM Core development, we should probably implement that Base class rather than handle web hooks via a class the extends CRM_Core_Page

@jmcclelland
Copy link
Contributor Author

And create unit tests to ensure that our IPN code continues to work.

I'm happy to work on this ticket.

@jmcclelland
Copy link
Contributor Author

I've created unit tests via #224

jmcclelland added a commit to progressivetech/com.drastikbydesign.stripe that referenced this issue Jul 6, 2017
This allows use of webhook in format /civicrm/payment/ipn/N

drastik#221
@jmcclelland
Copy link
Contributor Author

Tests are created - and this pull requests does it all: #225 and passes all tests.

Note: this has no impact by default - it will only be used if people switch to the standard CiviCRM IPN handling URL (civicrm/payment/ipn/N).

jmcclelland added a commit to progressivetech/com.drastikbydesign.stripe that referenced this issue Oct 25, 2017
This allows use of webhook in format /civicrm/payment/ipn/N

drastik#221
jmcclelland added a commit to progressivetech/com.drastikbydesign.stripe that referenced this issue Nov 27, 2017
This allows use of webhook in format /civicrm/payment/ipn/N

drastik#221
jmcclelland added a commit to progressivetech/com.drastikbydesign.stripe that referenced this issue Mar 19, 2018
This allows use of webhook in format /civicrm/payment/ipn/N

drastik#221
scardinius pushed a commit to WeMoveEU/com.drastikbydesign.stripe that referenced this issue Nov 18, 2020
… CiviCRM. Look for contribution using subscription_id for future recurring start date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants