-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.10.0 #65
Merged
Merged
v0.10.0 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make set_scg and set_chem kwargs only * Ensure all params exist for set_chem * SL specific errors * Initial implementation of retrying requests * Fix logging * Use async_make_request * Retry tests * Expose retry count to gateway async_send_message * Set max_retries on gateway * Variable CLIENT_ID (#43) * Support specifying client_id, otherwise random * Take client_id at gateway instantiation not host * Update `MockConnectedGateway` to late connect * Update tests * Update to late connect * Allow setting max_retries at instantiate * Changes to instantiate. Formatting. * Make changelogs lists * Wording. * Move .decode into getString * Additional message code notes * Latest data example * Late connect for MockConnectedGateway * Make set_scg kwargs only * Reorder get/set * Make set_scg and set_chem kwargs only * Ensure all params exist for set_chem * SL specific errors * Latest data example * Make set_scg kwargs only * Fix output with 0 * New output format * Update set chem test * Merge fixes * Fixes for python 3.8 * New data validation * SCG and Chem settings moved to optional args * Update for optional args * Updates for optional args * Account for 0 being falsy * Refactor CLI * Deprecate support for Python 3.8 * Refactor option * Refactor validation * Possible ultra temp equip flag * Fix calcium hardness spelling * SLValueRange for limits, ON_OFF.from_bool returns enum * Force kwargs for chem_data and scg_config * Tests for cli updates * Handle missing existing values for kwarg methods
…LI (#54) * Test Fixture refactor * Initial data sets * Save adapter version debug response * ScreenLogicResponseCollection * Data sets for test_decode * repr tuples in json * Data export CLI option * Test refactor to use json data * Move response handling into individual methods for patching. * Remove unused alt login function * Standardize mock protocol adapter naming * Test login coverage * Simplify process_discovery_response * Test discovery coverage * cleanup * Test data coverage * SLIntEnum cleanup * Remove CLIFormat
* Spec v0.10.0, Target python 3.10 * Prep v0.10.0 documentation
* New exception classes * Raise exception on unexpected response * Raise exceptions for undesirable responses * Fix condition typo * Standardize if statement * Exception refactor * Use new exceptions * Update for new exceptions * Replace deleted debug output * Update ping for new exception * Raise connection error when future canceled and connection is closed * Test updates
* Time utilities; Support SL utf-16 string encoding. * Update autoDST to int * Support getting and setting date+time * Identified tz_adjust * v0.9.0 updates * Time utilities; Support SL utf-16 string encoding. * CLI support * Update .gitignore * Fix Hardness * New exception handling * Remove duplicate getTime * Update kwargs format * Datetime command functions * Updated response collection for v0.10.0 * Test date_time cli * Handle date_time requests * SCG state uses value * auto_dst as dict * Include date_time in data export * Zero out seconds in encoded time * Correct aDST to int * Flip success logic * Set current date-time if no parameters specified * Updated for no parameter date-time * Fix auto_dst dict path
This was
linked to
issues
Dec 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScreenLogicException
:ScreenLogicCommunicationError
- Base class for all communication errors.ScreenLogicRequestError
- Protocol adapter indicated an unknown or malformed request.ScreenLogicConnectionError
- Connection to the protocol adapter was lost.ScreenLogicResponseError
- Protocol adapter returned an unexpected response.ScreenLogicLoginError
- The login was explicitly rejected.bool
indicating success. Instead an appropriate exception will be raised if an error is encountered.