Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert set_scg and set_chem to keyword arguments only #36

Closed
4 of 5 tasks
dieselrabbit opened this issue Feb 16, 2023 · 0 comments · Fixed by #53 or #65
Closed
4 of 5 tasks

Convert set_scg and set_chem to keyword arguments only #36

dieselrabbit opened this issue Feb 16, 2023 · 0 comments · Fixed by #53 or #65
Assignees
@dieselrabbit
Labels
backend Improvement not user-facing CLI Issue affects the command line interface on hold Work is paused to do Internal issue for task tracking

Comments

@dieselrabbit
Copy link
Owner

dieselrabbit commented Feb 16, 2023 •
edited
Loading

async_set_scg_config and async_set_chem_data use message codes that set multiple values on the Screenlogic system.

Convert functions to accept only keyword arguments and populate missing values from current ones.

  • Simplifies calling code
    • CLI
    • HA number entity functionality
  • Groundwork for additional number entities in HA
    • Super chlorinate
    • Chemistry data
  • Needs CLI argparse support
@dieselrabbit dieselrabbit added to do Internal issue for task tracking backend Improvement not user-facing in progress Currently being worked on on hold Work is paused CLI Issue affects the command line interface and removed in progress Currently being worked on labels Feb 16, 2023
@dieselrabbit dieselrabbit linked a pull request Sep 4, 2023 that will close this issue
Make set_scg_config and set_chem_data kwargs only #53
Merged
@dieselrabbit dieselrabbit self-assigned this Nov 3, 2023
@dieselrabbit dieselrabbit linked a pull request Dec 1, 2023 that will close this issue
v0.10.0 #65
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dieselrabbit dieselrabbit

Labels
backend Improvement not user-facing CLI Issue affects the command line interface on hold Work is paused to do Internal issue for task tracking
Projects
None yet
Milestone
No milestone
1 participant
@dieselrabbit