Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable Release 2.0.0 #155

Merged
merged 4 commits into from
Jul 29, 2024
Merged

chore: enable Release 2.0.0 #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f92e5c
Update versions to 2.0.0 and fix base url to production
seakayone Jul 29, 2024
d69e90d
Merge branch 'main' into chore/release-2.0.0
seakayone Jul 29, 2024
7e497cf
Merge branch 'main' into chore/release-2.0.0
seakayone Jul 29, 2024
9922ef2
Merge branch 'main' into chore/release-2.0.0
seakayone Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dsp-domain/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "dsp-domain"
version = "0.1.3"
version = "2.0.0"
edition.workspace = true
license.workspace = true
homepage.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion dsp-meta-cmd/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "dsp-meta-cmd"
version = "0.1.3"
version = "2.0.0"
edition.workspace = true
license.workspace = true
homepage.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion dsp-meta-cmd/src/main-server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@

let base_url = settings
.get::<Url>("base_url")
.unwrap_or(Url::parse("http://localhost:3000").unwrap());
.unwrap_or(Url::parse("https://meta.dasch.swiss").unwrap());

Check warning on line 70 in dsp-meta-cmd/src/main-server.rs

View check run for this annotation

Codecov / codecov/patch

dsp-meta-cmd/src/main-server.rs#L70 

Added line #L70 was not covered by tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this change affect the local development?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we currently have not possibility to provide a configuration to the deployment. It is hardcoded in the Go service as well, e.g. https://meta.stage.dasch.swiss/robots.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a followup I have created DEV-3935


let shared_state = Arc::new(AppState {
project_metadata_service: ProjectMetadataService::new(ProjectMetadataRepository::new(
Expand Down
2 changes: 1 addition & 1 deletion dsp-meta/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ authors.workspace = true
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
dsp-domain = { path = "../dsp-domain", version = "0.1.3" }
dsp-domain = { path = "../dsp-domain", version = "2.0.0" }
anyhow.workspace = true
axum.workspace = true
axum-macros.workspace = true
Expand Down