chore: enable Release 2.0.0 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seakayone
commented
Jul 29, 2024
•
seakayone
commented
- Update versions to 2.0.0
- Fix base url to production
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
mpro7
reviewed
Jul 29, 2024
| @@ -67,7 +67,7 @@ async fn init_server() { | |||
|
|
|||
| let base_url = settings | |||
| .get::<Url>("base_url") | |||
| .unwrap_or(Url::parse("http://localhost:3000").unwrap()); | |||
| .unwrap_or(Url::parse("https://meta.dasch.swiss").unwrap()); | |||
There was a problem hiding this comment.
will this change affect the local development?
There was a problem hiding this comment.
we currently have not possibility to provide a configuration to the deployment. It is hardcoded in the Go service as well, e.g. https://meta.stage.dasch.swiss/robots.txt
There was a problem hiding this comment.
As a followup I have created DEV-3935
BalduinLandolt
approved these changes
Jul 29, 2024
This was referenced Jul 29, 2024
Merged
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.