Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure that mocks are setup in isolation on each test #5161

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

petebacondarwin
Copy link
Contributor

What this PR solves / how to test

Tests are failing because they shared state between tests.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included - it is a test change!
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: no public facing change
  • Public documentation

@petebacondarwin petebacondarwin requested a review from a team as a code owner March 5, 2024 10:32
Copy link

changeset-bot bot commented Mar 5, 2024

⚠️ No Changeset found

Latest commit: 27471d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155203480/npm-package-wrangler-5161

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5161/npm-package-wrangler-5161

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155203480/npm-package-wrangler-5161 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155203480/npm-package-create-cloudflare-5161 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155203480/npm-package-cloudflare-kv-asset-handler-5161
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155203480/npm-package-miniflare-5161
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155203480/npm-package-cloudflare-pages-shared-5161
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155203480/npm-package-cloudflare-vitest-pool-workers-5161

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.30.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.35%. Comparing base (93e83b1) to head (27471d6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5161      +/-   ##
==========================================
+ Coverage   70.31%   70.35%   +0.03%     
==========================================
  Files         298      298              
  Lines       15551    15551              
  Branches     4001     4001              
==========================================
+ Hits        10935    10941       +6     
+ Misses       4616     4610       -6     

see 6 files with indirect coverage changes

@petebacondarwin petebacondarwin merged commit 24b4c42 into main Mar 5, 2024
22 checks passed
@petebacondarwin petebacondarwin deleted the fix-leaking-tests branch March 5, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants