ci: disable file parallelism for fixture tests #5159
Conversation
|
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8157203385/npm-package-wrangler-5159You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5159/npm-package-wrangler-5159Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8157203385/npm-package-wrangler-5159 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8157203385/npm-package-create-cloudflare-5159 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8157203385/npm-package-cloudflare-kv-asset-handler-5159npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8157203385/npm-package-miniflare-5159npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8157203385/npm-package-cloudflare-pages-shared-5159npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8157203385/npm-package-cloudflare-vitest-pool-workers-5159Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
|
Blocked on #5161 |
Some of the `get-{bindings,platform}-proxy` tests have been flaking in
CI recently. I think this is because they're trying to connect to the
dev registry, but the dev registry was started by an earlier test that
just finished. This leads to socket errors like `other side closed`.
The proper solution to this problem is to start a dev registry for
each test (file). We could do this by assigning a different dev
registry port for each test (file/project). In the meantime, this
change disables parallelism for the fixture tests, ensuring if a dev
registry is started, it is definitely shut down before another test
begins.
mrbbot
force-pushed
the
bcoll/disable-vitest-parallelism
branch
from
3f3bc63 to
7289973
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5159 +/- ##
==========================================
+ Coverage 70.31% 70.36% +0.04%
==========================================
Files 298 298
Lines 15551 15551
Branches 4001 4001
==========================================
+ Hits 10935 10942 +7
+ Misses 4616 4609 -7 |
What this PR solves / how to test
Some of the
get-{bindings,platform}-proxytests have been flaking in CI recently. I think this is because they're trying to connect to the dev registry, but the dev registry was started by an earlier test that just finished. This leads to socket errors likeother side closed. The proper solution to this problem is to start a dev registry for each test (file). We could do this by assigning a different dev registry port for each test (file/project). In the meantime, this change disables parallelism for the fixture tests, ensuring if a dev registry is started, it is definitely shut down before another test begins.Author has addressed the following