Skip to content

Commit

Permalink
ci: disable file parallelism for fixture tests (#5159)
Browse files Browse the repository at this point in the history
Some of the `get-{bindings,platform}-proxy` tests have been flaking in
CI recently. I think this is because they're trying to connect to the
dev registry, but the dev registry was started by an earlier test that
just finished. This leads to socket errors like `other side closed`.
The proper solution to this problem is to start a dev registry for
each test (file). We could do this by assigning a different dev
registry port for each test (file/project). In the meantime, this
change disables parallelism for the fixture tests, ensuring if a dev
registry is started, it is definitely shut down before another test
begins.
  • Loading branch information
mrbbot authored Mar 5, 2024
1 parent 907fb77 commit 24ff22b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"fix": "pnpm run prettify && dotenv -- turbo check:lint -- --fix",
"prettify": "prettier . --write --ignore-unknown",
"test": "dotenv -- turbo test",
"test:ci": "vitest run && dotenv -- turbo test:ci --filter=wrangler --filter=miniflare --filter=kv-asset-handler --filter=@cloudflare/vitest-pool-workers",
"test:ci": "vitest run --no-file-parallelism && dotenv -- turbo test:ci --filter=wrangler --filter=miniflare --filter=kv-asset-handler --filter=@cloudflare/vitest-pool-workers",
"test:watch": "turbo test:watch",
"type:tests": "dotenv -- turbo type:tests",
"gen:package": "turbo gen package"
Expand Down Expand Up @@ -53,7 +53,7 @@
"node": ">=16.17.0"
},
"volta": {
"node": "16.13.0"
"node": "16.17.0"
},
"pnpm": {
"peerDependencyRules": {
Expand Down

0 comments on commit 24ff22b

Please sign in to comment.