-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3 - fix hono e2e tests #5149
C3 - fix hono e2e tests #5149
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8140247406/npm-package-wrangler-5149 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5149/npm-package-wrangler-5149 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8140247406/npm-package-wrangler-5149 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8140247406/npm-package-create-cloudflare-5149 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8140247406/npm-package-cloudflare-kv-asset-handler-5149 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8140247406/npm-package-miniflare-5149 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8140247406/npm-package-cloudflare-pages-shared-5149 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8140247406/npm-package-cloudflare-vitest-pool-workers-5149 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5149 +/- ##
==========================================
+ Coverage 70.32% 70.37% +0.05%
==========================================
Files 298 298
Lines 15542 15550 +8
Branches 3999 4000 +1
==========================================
+ Hits 10930 10944 +14
+ Misses 4612 4606 -6 |
What this PR solves / how to test
The hono C3 e2e tests are currently broken (see c3 hono e2es failing), this PR fixes this
Note
The dependabot PR that bumped
create-hono
from 0.4.0 to 0.5.0 should have caught thisbut it didn't if you look at the run logs (here) you can see that the e2es were run using
create-hono@0.4.0
instead ofcreate-hono@0.5.0
we need to investigate why that happened!
Author has addressed the following