Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new .env.example to packages/create-cloudflare project #5140

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

dario-piotrowicz
Copy link
Member

What this PR solves / how to test

Just a simple .env.example file to help developers with local debugging

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: not something that needs testing
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: not a user-facing change in any way
  • Public documentation

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner March 1, 2024 19:09
Copy link

changeset-bot bot commented Mar 1, 2024

⚠️ No Changeset found

Latest commit: 71d3610

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dario-piotrowicz dario-piotrowicz requested a review from jculvey March 1, 2024 19:10
Copy link
Contributor

github-actions bot commented Mar 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8142159523/npm-package-wrangler-5140

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5140/npm-package-wrangler-5140

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8142159523/npm-package-wrangler-5140 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8142159523/npm-package-create-cloudflare-5140 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8142159523/npm-package-cloudflare-kv-asset-handler-5140
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8142159523/npm-package-miniflare-5140
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8142159523/npm-package-cloudflare-pages-shared-5140
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8142159523/npm-package-cloudflare-vitest-pool-workers-5140

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.30.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (4194495) to head (71d3610).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5140      +/-   ##
==========================================
+ Coverage   70.31%   70.37%   +0.06%     
==========================================
  Files         298      298              
  Lines       15550    15550              
  Branches     4000     4000              
==========================================
+ Hits        10934    10944      +10     
+ Misses       4616     4606      -10     

see 7 files with indirect coverage changes

@dario-piotrowicz dario-piotrowicz force-pushed the create-cloudflare-env-example branch from b4e8edc to 231d88a Compare March 4, 2024 10:33
@dario-piotrowicz
Copy link
Member Author

The e2es are currently failing because of hono, those are getting fixed in #5149

@dario-piotrowicz dario-piotrowicz force-pushed the create-cloudflare-env-example branch from 231d88a to 71d3610 Compare March 4, 2024 14:50
Copy link
Contributor

@jculvey jculvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dario-piotrowicz dario-piotrowicz merged commit 040be5d into main Mar 4, 2024
22 checks passed
@dario-piotrowicz dario-piotrowicz deleted the create-cloudflare-env-example branch March 4, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants