Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python_workers compat flag instead of experimental #5148

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Use python_workers compat flag instead of experimental #5148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/nice-seals-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"miniflare": minor
"wrangler": minor
---

chore: bump `workerd` to [`1.20240304.0`](https://github.com/cloudflare/workerd/releases/tag/v1.20240304.0)
6 changes: 6 additions & 0 deletions .changeset/tender-cooks-cheer.md
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actually sure this needs a changeset. This PR is only changing tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep it since this PR also updates workerd to the version that requires the new compat flag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add another changeset for that bump?

Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"miniflare": minor
"wrangler": minor
---

fix: use python_workers compat flag for Python
2 changes: 1 addition & 1 deletion fixtures/python-worker/wrangler.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name = "dep-python-worker"
main = "src/index.py"
compatibility_flags = ["experimental"]
compatibility_flags = ["python_workers"]
compatibility_date = "2024-01-29"
2 changes: 1 addition & 1 deletion packages/miniflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"glob-to-regexp": "^0.4.1",
"stoppable": "^1.1.0",
"undici": "^5.28.2",
"workerd": "1.20240223.1",
"workerd": "1.20240304.0",
"ws": "^8.11.0",
"youch": "^3.2.2",
"zod": "^3.20.6"
Expand Down
4 changes: 2 additions & 2 deletions packages/miniflare/test/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ test("Miniflare: service binding to current worker", async (t) => {
if (pathname === "/callback") return new Response("callback");
const response = await env.SELF.fetch("http://placeholder/callback");
const text = await response.text();
return new Response("body:" + text);
return new Response("body:" + text);
}
}`,
});
Expand Down Expand Up @@ -822,7 +822,7 @@ test("Miniflare: python modules", async (t) => {
contents: `def add(a, b):\n return a + b`,
},
],
compatibilityFlags: ["experimental"],
compatibilityFlags: ["python_workers"],
});
t.teardown(() => mf.dispose());
const res = await mf.dispatchFetch("http://localhost");
Expand Down
2 changes: 1 addition & 1 deletion packages/wrangler/e2e/dev.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ describe("basic dev python tests", () => {
name = "${workerName}"
main = "index.py"
compatibility_date = "2023-01-01"
compatibility_flags = ["experimental"]
compatibility_flags = ["python_workers"]
`,
"index.py": dedent`
from js import Response
Expand Down
38 changes: 19 additions & 19 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading