-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use python_workers compat flag instead of experimental #5148
Conversation
🦋 Changeset detectedLatest commit: db123b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b3aa905
to
99f592b
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-wrangler-5148 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5148/npm-package-wrangler-5148 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-wrangler-5148 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-create-cloudflare-5148 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-cloudflare-kv-asset-handler-5148 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-miniflare-5148 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-cloudflare-pages-shared-5148 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-cloudflare-vitest-pool-workers-5148 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating these. We won't be able to land this without a workerd
bump to a version that includes the new flag: https://github.com/cloudflare/workers-sdk/actions/runs/8138977567/job/22241061215?pr=5148#step:8:549
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not actually sure this needs a changeset. This PR is only changing tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep it since this PR also updates workerd to the version that requires the new compat flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add another changeset for that bump?
@mrbbot I thought that may be the case, here is a bump in the workerd repo cloudflare/workerd#1761 |
99f592b
to
d3ba878
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5148 +/- ##
=======================================
Coverage 70.35% 70.36%
=======================================
Files 298 298
Lines 15543 15551 +8
Branches 4000 4001 +1
=======================================
+ Hits 10935 10942 +7
- Misses 4608 4609 +1 |
Should be ready for merge |
|
d3ba878
to
db123b8
Compare
What this PR solves / how to test
The new workerd requires python_workers compat flag for python.
Author has addressed the following