Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #5131

Merged
merged 2 commits into from
Mar 1, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
Fixes # [insert GH or internal issue number(s)].
## What this PR solves / how to test

**What this PR solves / how to test:**
Fixes #[insert GH or internal issue number(s)].

**Author has addressed the following:**
## Author has addressed the following

- Tests
- [x] TODO (before merge)
- [ ] Included
- [ ] Not necessary because:
- Changeset ([Changeset guidelines](https://github.com/cloudflare/workers-sdk/blob/main/CONTRIBUTING.md#changesets))
- [x] TODO (before merge)
- [ ] Included
- [ ] Not necessary because:
- Associated docs
- [ ] Issue(s)/PR(s):
- Public documentation
- [x] TODO (before merge)
- [ ] Cloudflare docs PR(s): [https://github.com/cloudflare/cloudflare-docs/pull/...]
- [ ] Not necessary because:
petebacondarwin marked this conversation as resolved.
Show resolved Hide resolved

<!--
**Note for PR author:**

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label `highlight pr review` so future reviewers can take inspiration and learn from it.
We want to celebrate and highlight awesome PR review!
If you think this PR received a particularly high-caliber review, please assign it the label `highlight pr review` so future reviewers can take inspiration and learn from it.
-->
Loading