-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR template #5131
Update PR template #5131
Conversation
- Makes it clear that the docs link is for a PR in the Cloudflare Docs repository - Adds a TODO checkbox to each of the required actions - Tidies up the formatting, hiding the "Note for Authors" from published PR descriptions
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-wrangler-5131 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5131/npm-package-wrangler-5131 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-wrangler-5131 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-create-cloudflare-5131 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-cloudflare-kv-asset-handler-5131 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-miniflare-5131 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-cloudflare-pages-shared-5131 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-cloudflare-vitest-pool-workers-5131 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5131 +/- ##
==========================================
+ Coverage 70.32% 70.37% +0.04%
==========================================
Files 298 298
Lines 15542 15542
Branches 3999 3999
==========================================
+ Hits 10930 10937 +7
+ Misses 4612 4605 -7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One minor comment. 👍
What this PR solves / how to test
Author has addressed the following