Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #5131

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Update PR template #5131

merged 2 commits into from
Mar 1, 2024

Conversation

petebacondarwin
Copy link
Contributor

What this PR solves / how to test

  • Makes it clear that the docs link is for a PR in the Cloudflare Docs repository
  • Adds a TODO checkbox to each of the required actions
  • Tidies up the formatting, hiding the "Note for Authors" from published PR descriptions

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: GH configuration change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: no deployable change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s): [https://github.com/cloudflare/cloudflare-docs/pull/...]
    • Not necessary because: no public facing change

- Makes it clear that the docs link is for a PR in the Cloudflare Docs repository
- Adds a TODO checkbox to each of the required actions
- Tidies up the formatting, hiding the "Note for Authors" from published PR descriptions
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 1, 2024 09:38
Copy link

changeset-bot bot commented Mar 1, 2024

⚠️ No Changeset found

Latest commit: 24eb7e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-wrangler-5131

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5131/npm-package-wrangler-5131

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-wrangler-5131 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-create-cloudflare-5131 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-cloudflare-kv-asset-handler-5131
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-miniflare-5131
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-cloudflare-pages-shared-5131
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8110728971/npm-package-cloudflare-vitest-pool-workers-5131

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.30.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (5b11492) to head (24eb7e5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5131      +/-   ##
==========================================
+ Coverage   70.32%   70.37%   +0.04%     
==========================================
  Files         298      298              
  Lines       15542    15542              
  Branches     3999     3999              
==========================================
+ Hits        10930    10937       +7     
+ Misses       4612     4605       -7     

see 6 files with indirect coverage changes

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor comment. 👍

.github/pull_request_template.md Outdated Show resolved Hide resolved
@petebacondarwin petebacondarwin merged commit 89350a0 into main Mar 1, 2024
17 checks passed
@petebacondarwin petebacondarwin deleted the update-pr-templates branch March 1, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants