Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deribit Generic Fetcher + MerkleFeedMixin #150

Merged
merged 84 commits into from
Jul 26, 2024
Merged

Conversation

akhercha
Copy link
Member

@akhercha akhercha commented Jul 18, 2024

Closes #155

Introduced changes

Added

  • GenericEntry type
  • DeribitGenericFetcher for Deribit options in a new generic fetchers module,
  • MerkleTree creation & root passed into a GenericEntry,
  • MerkleFeedMixin placeholder - need the cairo spec
  • push_entries can now receive GenericEntry

@akhercha akhercha marked this pull request as ready for review July 18, 2024 18:13
@akhercha akhercha force-pushed the feat/deribit_fetcher branch from 6926018 to b3b0a1e Compare July 24, 2024 06:22
@akhercha akhercha mentioned this pull request Jul 25, 2024
@EvolveArt EvolveArt force-pushed the master branch 2 times, most recently from d94ef2c to a37607c Compare July 26, 2024 17:00
Copy link
Contributor

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just missing some tests created the issue #169

@EvolveArt EvolveArt merged commit 3c7942a into master Jul 26, 2024
9 of 10 checks passed
@EvolveArt EvolveArt deleted the feat/deribit_fetcher branch July 26, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Deribit Fetcher + MerkleFeedMixin
2 participants