-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deribit Generic Fetcher + MerkleFeedMixin #150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhercha
force-pushed
the
feat/deribit_fetcher
branch
from
July 24, 2024 06:22
6926018
to
b3b0a1e
Compare
Merged
…-sdk into feat/deribit_fetcher
EvolveArt
reviewed
Jul 26, 2024
pragma-sdk/pragma_sdk/common/fetchers/generic_fetchers/deribit.py
Outdated
Show resolved
Hide resolved
pragma-sdk/pragma_sdk/common/fetchers/generic_fetchers/deribit.py
Outdated
Show resolved
Hide resolved
pragma-sdk/pragma_sdk/common/fetchers/generic_fetchers/deribit.py
Outdated
Show resolved
Hide resolved
pragma-sdk/pragma_sdk/common/fetchers/generic_fetchers/deribit.py
Outdated
Show resolved
Hide resolved
pragma-sdk/pragma_sdk/common/fetchers/generic_fetchers/deribit.py
Outdated
Show resolved
Hide resolved
pragma-sdk/pragma_sdk/common/fetchers/generic_fetchers/deribit.py
Outdated
Show resolved
Hide resolved
pragma-sdk/pragma_sdk/common/fetchers/generic_fetchers/deribit.py
Outdated
Show resolved
Hide resolved
Co-authored-by: 0xevolve <Artevolve@yahoo.com>
Co-authored-by: 0xevolve <Artevolve@yahoo.com>
Co-authored-by: 0xevolve <Artevolve@yahoo.com>
EvolveArt
force-pushed
the
master
branch
2 times, most recently
from
July 26, 2024 17:00
d94ef2c
to
a37607c
Compare
EvolveArt
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just missing some tests created the issue #169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155
Introduced changes
Added
GenericEntry
typeDeribitGenericFetcher
for Deribit options in a new generic fetchers module,MerkleTree
creation & root passed into aGenericEntry
,MerkleFeedMixin
placeholder - need the cairo specpush_entries
can now receiveGenericEntry