Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated typed_data following starknet.py bump #88

Merged
merged 13 commits into from
Jul 27, 2024

Conversation

akhercha
Copy link
Member

@akhercha akhercha commented Jul 18, 2024

Linked to:
astraly-labs/pragma-sdk#155

Work done

Following the starknet.py version bump, the way to use TypedData has slightly change and requires now two new fields (mandatory). They've been added so the offchain publishing works correctly (tested locally & it works ✅).

Currently, the function has a is_legacy argument for messages still signed the old way. We want to support that for 1-2 months than delete it.

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 12.06%. Comparing base (4304e56) to head (11a3dcd).
Report is 2 commits behind head on main.

Files Patch % Lines
pragma-node/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   12.37%   12.06%   -0.32%     
==========================================
  Files          56       57       +1     
  Lines        3992     4129     +137     
==========================================
+ Hits          494      498       +4     
- Misses       3498     3631     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol comment

pragma-node/src/utils/signing/mod.rs Outdated Show resolved Hide resolved
@EvolveArt EvolveArt merged commit 3c4b563 into main Jul 27, 2024
5 checks passed
@EvolveArt EvolveArt deleted the fix/new_typed_data branch July 27, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants