-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updated typed_data following starknet.py bump #88
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 12.37% 12.06% -0.32%
==========================================
Files 56 57 +1
Lines 3992 4129 +137
==========================================
+ Hits 494 498 +4
- Misses 3498 3631 +133 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smol comment
Linked to:
astraly-labs/pragma-sdk#155
Work done
Following the
starknet.py
version bump, the way to useTypedData
has slightly change and requires now two new fields (mandatory). They've been added so the offchain publishing works correctly (tested locally & it works ✅).Currently, the function has a
is_legacy
argument for messages still signed the old way. We want to support that for 1-2 months than delete it.