Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for values passed to onUpdate hook #40

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fixes for values passed to onUpdate hook #40

merged 1 commit into from
Oct 25, 2023

Conversation

veelci
Copy link
Contributor

@veelci veelci commented Oct 24, 2023

  • don't call onUpdate with values having invalid lengths
  • strip spaces

@veelci
fixes for value passed to onUpdate hook
898f0c2 
* don't pass back invalid values
* strip spaces
@veelci veelci mentioned this pull request Oct 24, 2023
Closed
@veelci
Copy link
Contributor Author

veelci commented Oct 25, 2023

@arenoir Can you please take a look at this when you have a chance?

@arenoir arenoir merged commit e69444c into arenoir:main Oct 25, 2023
7 of 11 checks passed
@arenoir
Copy link
Owner

arenoir commented Oct 25, 2023

Hi @veelci, thanks for putting this together. I will merge this into main and cut a 2.0.0-1 pre-release shortly. I think given the new format of the onUpdate value this should be considered a breaking change.

@veelci
Copy link
Contributor Author

veelci commented Oct 25, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veelci @arenoir