Upgrading to latest ember

[pdud]

Hey @arenoir!

We love your add-on and have been using it for years! Thanks so much! 🙌

We're in the midsts of upgrading to Ember 4 and found some add ons that required updating including this one.

I've got three PRs ready to go for ember-credit-cards that can be seen passing on my fork.

1. Adding github actions CI
2. Upgrading to the ember 3.28, which is a breaking change because it drops node support.
3. Upgrading to octane/ glimmer/ removing deprecations for 4.0

Is this something you would be interested in?

[arenoir]

Yes absolutely. Thank you

[pdud]

Thanks so much for your interest!

I'll continue with my ember 4.0 upgrade and make sure it's got all it needs to be ready for 4.0. I'll loop back at a later date. Thanks again!

[arenoir]

Thanks @pdud, let me know and I will publish a new version to npm.

[veelci]

@pdud I'm currently running my app with your changes and I've noticed that the "onUpdate" argument of the InputCreditCardNumber component is called for invalid credit card numbers, but the value of the input component is not updated.

You should be able to reproduce this by inputting an extra 1 after "4111111111111111" and should be able to see that "41111111111111111" (with the extra 1) is passed back via onUpdate.

[pdud]

Thanks for reporting @veelci! I expect to have capacity to get this fixed in November. Do you want to try put in a PR before then?

[veelci]

@pdud. Sure - I've opened #40 that fixes this and also strips spaces out from values being passed back via onUpdate()

[pdud]

Thank you both for your work here! 👏