Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gh actions #3

Merged
merged 74 commits into from
Dec 13, 2023
Merged

add gh actions #3

merged 74 commits into from
Dec 13, 2023

Conversation

bou3108
Copy link
Collaborator

@bou3108 bou3108 commented Dec 6, 2023

ajout des github actions de tests et de génération

@bou3108 bou3108 self-assigned this Dec 6, 2023
@bou3108 bou3108 requested a review from romainfd December 6, 2023 13:42
Copy link
Collaborator

@romainfd romainfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un peu de nettoyage à faire des fichiers qui sont .gitignorés maintenant mais sinon ça me parait top ! Excellent le README, merci !!
Voir aussi pourquoi les tests plantent ?

.github/workflows/test-coverage.yaml Outdated Show resolved Hide resolved
.github/workflows/test-coverage.yaml Outdated Show resolved Hide resolved
.gradle/8.2/checksums/checksums.lock Outdated Show resolved Hide resolved
gradle/wrapper/gradle-wrapper.jar Outdated Show resolved Hide resolved
gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
gradlew Outdated Show resolved Hide resolved
Copy link

File Coverage [45.17%]
Contact.java 64.53% 🍏
Victims.java 63.66% 🍏
ContactSource.java 61.54% 🍏
ExternalInfo.java 61.41% 🍏
DistributionElement.java 55.31%
Coord.java 51.63%
Sender.java 45.45%
Recipient.java 45.45%
Alert.java 43.89%
Reference.java 40.96%
Qualification.java 38.25%
CreateCase.java 38.24%
Location.java 38.24%
Attachment.java 37.74%
CallTaker.java 37.67%
CustomMap.java 37.57%
Geometry.java 37.42%
WayName.java 37.42%
Nomenclature.java 37.42%
City.java 37.42%
DetailedName.java 37.42%
DetailedAdress.java 37.42%
Access.java 37.21%
CreateCaseWrapper.java 37.21%
ReferenceWrapper.java 37.21%
Point.java 37.19%
Caller.java 35.05%
AdditionalInformation.java 34.94%
Total Project Coverage 60.32% 🍏

Copy link

File Coverage [46.78%]
CreateCaseWrapperBuilder.java 100% 🍏
ReferenceWrapperBuilder.java 100% 🍏
DistributionElementBuilder.java 82.91% 🍏
Contact.java 64.53% 🍏
Victims.java 63.66% 🍏
ContactSource.java 61.54% 🍏
ExternalInfo.java 61.41% 🍏
DistributionElement.java 55.31%
Coord.java 51.63%
Sender.java 45.45%
Recipient.java 45.45%
Alert.java 43.89%
Reference.java 40.96%
Qualification.java 38.25%
CreateCase.java 38.24%
Location.java 38.24%
Attachment.java 37.74%
CallTaker.java 37.67%
CustomMap.java 37.57%
Geometry.java 37.42%
WayName.java 37.42%
Nomenclature.java 37.42%
City.java 37.42%
DetailedName.java 37.42%
DetailedAdress.java 37.42%
Access.java 37.21%
CreateCaseWrapper.java 37.21%
ReferenceWrapper.java 37.21%
Point.java 37.19%
Caller.java 35.05%
AdditionalInformation.java 34.94%
Total Project Coverage 60.32% 🍏

Copy link

File Coverage [72.4%] 🍏
CreateCaseWrapperBuilder.java 100% 🍏
ReferenceWrapperBuilder.java 100% 🍏
Nomenclature.java 96.71% 🍏
Caller.java 93.1% 🍏
Etype.java 92.46% 🍏
Location.java 91.11% 🍏
Egeo.java 89.15% 🍏
Mission.java 84.48% 🍏
DistributionElementBuilder.java 82.91% 🍏
Contact.java 64.53% 🍏
Victims.java 63.66% 🍏
ContactSource.java 61.54% 🍏
ExternalInfo.java 61.41% 🍏
Event.java 54.98%
Context.java 53.92%
Link.java 51.76%
Coord.java 51.63%
DistributionElement.java 44.69%
Alert.java 43.89%
Reference.java 40.96%
Position.java 38.62%
Qualification.java 38.25%
Emsi.java 38.25%
CreateCase.java 38.24%
Casualties.java 37.85%
Attachment.java 37.74%
CallTaker.java 37.67%
CustomMap.java 37.57%
Geometry.java 37.42%
WayName.java 37.42%
City.java 37.42%
DetailedName.java 37.42%
DetailedAdress.java 37.42%
Evac.java 37.42%
Origin.java 37.42%
Coord.java 37.42%
Access.java 37.21%
CreateCaseWrapper.java 37.21%
EmsiWrapper.java 37.21%
ReferenceWrapper.java 37.21%
Point.java 37.19%
Reference.java 37.01%
AdditionalInformation.java 34.94%
Sender.java 22.31%
Recipient.java 22.31%
ExternalInfo.java 18.8%
PositionEgeo.java 0%
PositionRgeo.java 0%
Total Project Coverage 71.61% 🍏

@bou3108 bou3108 requested a review from romainfd December 13, 2023 14:21
csv_parser/csv_parser.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@romainfd romainfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's go !
@bou3108 suite à notre point mardi, on avait décidé de passé à recipient et de reprendre les templates des wrappers pour enlever tous les "if parent" en attendant la tâche qui reprendra ça proprement : https://app.asana.com/0/1203993034002721/1206152866230293/f
Mais le point sur les templates des wrappers est quelque part ?

@romainfd romainfd merged commit a03553f into main Dec 13, 2023
1 check failed
@romainfd romainfd deleted the feat/add-gh-action branch December 13, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants