Show Blocking dialog While Sending File. Lay Groundwork For Progress Bar #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycb
force-pushed
the
fileSendBlocking
branch
from
803e3c5 to
9c6db28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #25
This change adds a blocking dialog when a large file is being transferred to prevent the user from clicking on the app's navigation buttons.
The issue specifically asks for a progress bar to be added, this change adds the necessary reporting to add this, however as the file transfer currently takes place in the Electron renderer thread, there are issues where Angular is blocked from processing the updates util the transfer is finished. This should be resolved going forward by either moving the printer SDK into the Electron main process or using a web worker for the transfer.
Both of these options require significant refactoring, so for this release (1.2) I'm opting to fix only the top level bug of sometimes the progress ring is not shown and sometimes is possible to interrupt the transfer by clicking away. I'll revisit the progress bar in a later release.