Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar while sending file to printer #25

Open
noquierouser opened this issue Dec 30, 2020 · 6 comments · Fixed by #46
Open

Progress bar while sending file to printer #25

noquierouser opened this issue Dec 30, 2020 · 6 comments · Fixed by #46
Assignees
Labels
enhancement New feature or request

Comments

@noquierouser
Copy link

While sending large files, there's no way to know the file is being sent until the success message is shown.

If no progress bar is possible, show that a file is being sent until the process is completed.

@andycb
Copy link
Owner

andycb commented Dec 30, 2020

I think a progress bar should be achievable. Just to check though – in the current version, are you seeing the indeterminate spinner while it transfers, or just a pause?

@andycb andycb added the enhancement New feature or request label Dec 30, 2020
@noquierouser
Copy link
Author

I see no spinner, just a pause. But if I change the active tab while it's transferring the file, it won't be sent properly.

@andycb
Copy link
Owner

andycb commented Dec 31, 2020

Ah interesting. Its supposed to have a little spinner like this. I'll have to investigate what's happened to it. I’ll give a little thought to the best way of blocking the other tabs while transferring – I might make the whole wait UI into a dialog.

image

To help get to the bottom of it would you mind answering aome questions:

  • What platform are you running on [Windows .exe / Windows Store / MacOS]?
  • Are you seeing this on Adventurer Client 1.0 or 1.1?
  • Are you seeing this in light or dark mode?

Thanks

@andycb andycb added bug Something isn't working and removed enhancement New feature or request labels Dec 31, 2020
@noquierouser
Copy link
Author

noquierouser commented Dec 31, 2020

I've seen the spinner a couple of times. On large files it can be seen as well, but sometimes I've got no reaction from UI. This might be coupled with some times when the Status tab also shows no information.

  • What platform are you running on [Windows .exe / Windows Store / MacOS]?

Windows Store

  • Are you seeing this on Adventurer Client 1.0 or 1.1?

Latest in Store, 1.1.143.

  • Are you seeing this in light or dark mode?

Dark mode.

@noquierouser
Copy link
Author

Spinner while uploading a large file, but UI elements are still clickable.

I recently tried this with a 25 MB file, and while it was sending the file I was able to click the Status tab which blew the sending process, and silently failed. Also, I had no way to know how much file was sent before failure.

@andycb
Copy link
Owner

andycb commented Jan 2, 2021

I think I'll make this UI a blocking dialog while its transferring - The status page wouldn’t be able to show any information while a transfer in in progress anyway, as the printer connection will be in transfer mode when it works a little differently.

@andycb andycb added this to the V1.2 milestone Jan 2, 2021
@andycb andycb self-assigned this Jan 19, 2021
@andycb andycb added the in progress This issue is being worked on by somebody at the moment label Jan 19, 2021
@andycb andycb reopened this Feb 12, 2021
@andycb andycb added enhancement New feature or request and removed bug Something isn't working in progress This issue is being worked on by somebody at the moment labels Feb 12, 2021
@andycb andycb removed this from the V1.2 milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants